fix: revert labels config + strengthen responder resolve-before-push#109
fix: revert labels config + strengthen responder resolve-before-push#109
Conversation
There was a problem hiding this comment.
Pull request overview
Reverts the safe-outputs.create-pull-request.labels configuration in the Issue Implementer workflow to avoid gh-aw’s unreliable post-creation label application and restore instruction-driven labeling.
Changes:
- Removed
labels: ["aw"]from.github/workflows/issue-implementer.mdsafe-outputs config. - Recompiled
.github/workflows/issue-implementer.lock.ymlto remove the “Labels will be automatically added” tool description and the handler’slabelsconfig.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/issue-implementer.md | Removes safe-output labels config so the agent must include labels during PR creation. |
| .github/workflows/issue-implementer.lock.yml | Updates compiled workflow to reflect the removed labels config/tool description and handler config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
microsasa
force-pushed
the
fix/revert-labels-config
branch
from
e32d895 to
b0b8aa5
Compare
microsasa
changed the title
microsasa
force-pushed
the
fix/revert-labels-config
branch
from
b0b8aa5 to
0a19288
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates gh-aw workflow configuration and documentation to (1) avoid flaky label application by reverting create-pull-request.labels safe-output config and (2) harden the Review Responder’s “resolve threads before push” ordering to prevent stale thread IDs from blocking merges.
Changes:
- Remove
labels: ["aw"]from Issue Implementer safe-outputs config and regenerate the compiled lock file accordingly. - Rewrite Review Responder instructions to emphasize “push last” and “resolve threads before push” ordering.
- Document the
create-pull-request.labelsruntime issue and add changelog entries describing the regressions and fixes.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/changelog.md | Adds an entry describing the labels-config revert and responder ordering hardening. |
| docs/agentic-workflows.md | Documents the broken labels: config behavior and adds timeline notes about the incidents. |
| .github/workflows/review-responder.md | Strengthens step ordering guidance to resolve/reply before any push. |
| .github/workflows/issue-implementer.md | Reverts the labels: ["aw"] safe-output config. |
| .github/workflows/issue-implementer.lock.yml | Regenerated compilation output removing labels auto-add behavior and handler config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Remove labels: ["aw"] from issue-implementer create-pull-request config. The config-level labels feature has a gh-aw runtime bug where the post-creation label API call fails non-deterministically. Closes #107, refs #108. - Rewrite review-responder instructions with explicit ordering: PUSH AS LAST STEP, MUST resolve before push, DOUBLE CHECK ordering. Closes #95. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
microsasa
force-pushed
the
fix/revert-labels-config
branch
from
0a19288 to
9b96b22
Compare
There was a problem hiding this comment.
Pull request overview
This PR hardens the repo’s gh-aw agent workflows by reverting a problematic create-pull-request labels configuration and strengthening Review Responder instructions to ensure review threads are resolved before any push.
Changes:
- Removed
labels: ["aw"]from Issue Implementer safe-outputs config and its compiled lock output to avoid unreliable post-creation labeling. - Rewrote Review Responder instructions to enforce “reply/resolve first, push last” ordering.
- Documented the above behaviors and added a changelog entry describing the incidents and fixes.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docs/changelog.md | Adds an entry documenting the labels-config revert and responder ordering hardening. |
| docs/agentic-workflows.md | Adds new “Common Pitfalls” items and extends the historical timeline with details of the incidents/fixes. |
| .github/workflows/review-responder.md | Strengthens step ordering to prevent thread-ID invalidation by pushing too early. |
| .github/workflows/issue-implementer.md | Removes labels: ["aw"] from create-pull-request safe-outputs config. |
| .github/workflows/issue-implementer.lock.yml | Regenerates compiled workflow output reflecting removal of labels config and tool description text. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes
1. Revert labels config on create-pull-request (closes #107, refs #108)
Removes
labels: ["aw"]from issue-implementer config. The gh-aw runtime has a bug where the post-creation label API call fails non-deterministically with a node ID resolution error. The tool description also tells the agent "labels will be automatically added" which causes the agent to stop including labels in its own call. Net result: labels never applied on failed runs.Reverts to instruction-based labeling which worked reliably for PRs #61-91.
2. Strengthen review-responder resolve-before-push instructions (closes #95)
Rewrote review-responder instructions with explicit ordering enforcement:
***PUSH AS LAST STEP***— sets the frame immediately***MUST***— resolve ALL threads before pushing***DOUBLE CHECK***— verify safe-output emission order***MUST***— every thread must be replied to and resolved***MUST***— push is the ONLY and LAST operationPrevious instruction was a single
**IMPORTANT**note that the agent ignored on PRs #91 and #106, leaving threads unresolved and blocking auto-merge.Closes #107, #95. Refs #108.