fix: quality gate waits for Copilot review and checks actual approval state

[microsasa]

Problem

#178 — Quality gate dispatched before Copilot review completes

The orchestrator dispatched the quality gate as soon as CI was green and threads were resolved, without checking whether Copilot had reviewed. Quality gate approved PRs before Copilot's review arrived — then Copilot's comments went unaddressed. Observed on PR #193 (4 unresolved threads at merge).

#187 — Quality gate label/approval desync

The orchestrator checked for aw-quality-gate-approved label to skip re-dispatch. But dismiss_stale_reviews: true dismisses the approval when new code is pushed while the label persists. Orchestrator saw the stale label and skipped, leaving PR stuck.

Fix

Replaced the label-based quality gate check (step 4) with three verification steps:

1. Copilot review exists — query latestReviews for copilot-pull-request-reviewer on current head commit via headRefOid. Skip if missing.
2. Copilot review not in progress — gh run list for active "Copilot code review" runs. Skip if any running (fail-safe: defaults to 1 on API error).
3. Valid approval check — query latestReviews for non-dismissed APPROVE from github-actions on current head commit. Only skip dispatch if valid approval exists.

Also added pitfalls #28 and #29 to agentic-workflows.md.

Fixes #178, #187

[Copilot]

Pull request overview

Updates the pipeline orchestrator logic so the quality gate won’t run (or be skipped) based on stale signals; instead it waits for Copilot review completion and verifies a current-commit approval state before deciding whether to dispatch the quality gate.

Changes:

• Extend orchestrator PR GraphQL query to include headRefOid and latestReviews, and use them to gate quality-gate dispatch on current-commit Copilot review + current-commit approval.
• Document two new orchestration pitfalls in agentic-workflows.md and record the change in docs/changelog.md.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
docs/changelog.md	Adds an entry describing the new quality-gate gating logic and rationale.
docs/agentic-workflows.md	Adds pitfalls #28/#29 documenting why orchestrator must wait for Copilot and check real approval state.
.github/workflows/pipeline-orchestrator.yml	Implements the new gating checks (Copilot review exists, no Copilot run in progress, valid approval on head commit).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.