Remove early return for empty messages in sendChatHistoryMessagesAsync

packages/agents-a365-tooling-extensions-openai/docs/design.md

@@ -295,7 +295,7 @@ The service handles automatic conversion of OpenAI message types:
 | `turnContext` is null/undefined | Throws `Error('turnContext is required')` |
 | `session` is null/undefined | Throws `Error('session is required')` |
 | `messages` is null/undefined | Throws `Error('messages is required')` |
-| `messages` is empty array | Returns `OperationResult.success` (no-op) |
+| `messages` is empty array | Makes MCP platform call with empty chat history |
 | Message conversion fails | Message is skipped, error logged |
 | HTTP error from MCP platform | Returns `OperationResult.failed()` with error |
 | Network timeout | Returns `OperationResult.failed()` with error |

packages/agents-a365-tooling-extensions-openai/src/McpToolRegistrationService.ts

@@ -168,11 +168,6 @@ export class McpToolRegistrationService {
       throw new Error('messages is required');
     }
 
-    // Handle empty list as no-op
-    if (messages.length === 0) {
-      return OperationResult.success;
-    }
-
     // Set default options
     const effectiveOptions: ToolOptions = {
       orchestratorName: toolOptions?.orchestratorName ?? this.orchestratorName

tests/tooling-extensions-openai/sendChatHistoryMessagesAsync.test.ts

@@ -70,13 +70,24 @@ describe('McpToolRegistrationService - sendChatHistoryMessagesAsync', () => {
       ).rejects.toThrow('messages is required');
     });
 
-    it('UV-05: should return success for empty array (no-op)', async () => {
+    it('UV-05: should make MCP platform call even with empty array', async () => {
+      mockedAxios.post.mockResolvedValue({ status: 200, data: {} });
       const result = await service.sendChatHistoryMessagesAsync(mockTurnContext, []);
 
       expect(result.succeeded).toBe(true);
       expect(result).toBe(OperationResult.success);
-      // Verify that no HTTP call was made
-      expect(mockedAxios.post).not.toHaveBeenCalled();
+      // Verify that HTTP call was made even with empty messages
+      expect(mockedAxios.post).toHaveBeenCalledTimes(1);
+      expect(mockedAxios.post).toHaveBeenCalledWith(
+        expect.any(String),
+        expect.objectContaining({
+          conversationId: 'conv-123',
+          messageId: 'msg-456',
+          userMessage: 'Current user message',
+          chatHistory: [], // Empty chat history
+        }),
+        expect.any(Object)
+      );
     });
   });