[release/2.x] Cherry pick: Add mutex locks to sample indexing strategies (#4075)

[github-actions]

Backports the following commits to release/2.x:

• Add mutex locks to sample indexing strategies (#4075)

[eddyashton]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[eddyashton]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[eddyashton]

A note for the future: The automatically created backport failed because it included #include "ccf/ds/pal.h and ccf::Pal::Mutex. We don't want to backport this breaking API change to 2.x, so I've manually edited those to refer to ccf::Mutex. Any future changes that reference the Pal will have to do the same.

[ghost]

backport/release/2.x/pr-4075@48591 aka 20220815.16 vs release/2.x ewma over 20 builds from 47758 to 48563

Click to see table

release/2.x

build_id	build_number	tpcc_sgx_cft^	tpcc_sgx_cft_mem	ls_sgx_cft^	ls_sgx_cft_mem	ls_jwt_sgx_cft^	ls_jwt_sgx_cft_mem	ls_js_sgx_cft^	ls_js_sgx_cft_mem	ls_v8_sgx_cft^	ls_v8_sgx_cft_mem	ls_full_js_sgx_cft^	ls_full_js_sgx_cft_mem	ls_full_v8_sgx_cft^	ls_full_v8_sgx_cft_mem	ls_js_jwt_sgx_cft^	ls_js_jwt_sgx_cft_mem	hist_sgx_cft^	RB put (/s)^	CHAMP put (/s)^	RB get (/s)^	CHAMP get (/s)^
47758	20220718.1	6572.79	8.42835e+07	20341.3	1.63882e+07	5687.11	1.53396e+07	2564.07	1.00967e+07	1653.28	1.62927e+08	2131.33	9.04813e+06	1462.82	9.84392e+07	1997.87	8.52384e+06	20478.4	897768	1.37476e+06	9.39445e+06	3.54319e+07
47793	20220719.2	6596.89	8.42835e+07	21005.9	1.6126e+07	5400.1	1.53396e+07	2557.15	1.00967e+07	1639.16	1.62927e+08	2137.49	9.31027e+06	1449.24	9.63421e+07	1936.41	8.78598e+06	20229.2	902476	1.36669e+06	9.20032e+06	3.58042e+07
47852	20220720.8	6634.56	8.40213e+07	20790.8	1.66503e+07	5497.38	1.56017e+07	2557.83	1.00967e+07	1652.48	1.61354e+08	2132.3	9.04813e+06	1473.69	9.79149e+07	1945.67	8.78598e+06	18297.8	926693	1.38107e+06	9.16737e+06	3.57417e+07
47907	20220721.3	6535.22	8.3497e+07	20647	1.6126e+07	5591.64	1.53396e+07	2554.82	1.03588e+07	1644.32	1.63451e+08	2129.85	9.04813e+06	1447.33	9.84392e+07	2030.07	8.78598e+06	18069.2	912850	1.38162e+06	9.21265e+06	3.59923e+07
47930	20220722.3	6545.63	8.32349e+07	20935.5	1.66503e+07	5756.45	1.53396e+07	2567.11	1.00967e+07	1660.79	1.63713e+08	2131.8	9.04813e+06	1465.32	9.81771e+07	1991.91	8.52384e+06	17928.7	910014	1.3687e+06	9.20445e+06	3.58669e+07
47962	20220725.2	6416.28	8.3497e+07	20759.4	1.6126e+07	5703.51	1.50774e+07	2479.04	1.00967e+07	1655.61	1.61354e+08	1971.76	9.04813e+06	1453.21	9.84392e+07	1930.14	8.78598e+06	17590.8	909489	1.3597e+06	9.18382e+06	3.58669e+07
47990	20220726.2	6643.16	8.37592e+07	20932.4	1.6126e+07	5649.69	1.53396e+07	2558.91	1.00967e+07	1640.97	1.63451e+08	2125.96	9.04813e+06	1441	9.81771e+07	1981.76	8.78598e+06	19480	901561	1.35718e+06	9.22099e+06	3.56174e+07
48051	20220727.1	6248.8	8.40213e+07	20588.1	1.6126e+07	5517.39	1.58639e+07	2563.55	1.00967e+07	1654.27	1.61092e+08	2134.26	1.08831e+07	1461.27	9.89635e+07	1732.07	1.00967e+07	19304.6	888228	1.36278e+06	9.2335e+06	3.57417e+07
48081	20220728.3	6468.48	8.40213e+07	20402.6	1.66503e+07	5611.9	1.50774e+07	2546.94	1.00967e+07	1627.57	1.6083e+08	2140.78	9.04813e+06	1445.27	9.81771e+07	1994.22	8.78598e+06	21009.9	897808	1.37237e+06	9.22099e+06	3.5189e+07
48117	20220729.3	6505.6	8.40213e+07	20673.3	1.76989e+07	5760.14	1.53396e+07	2558.19	1.00967e+07	1618.44	1.62927e+08	2090.96	1.2456e+07	1440.77	9.81771e+07	1943.9	8.78598e+06	20100.6	900967	1.36296e+06	9.34729e+06	3.58663e+07
48222	20220801.3	6368.1	8.40213e+07	20648.1	1.63882e+07	5590.31	1.50774e+07	2561.84	1.00967e+07	1629.2	1.62927e+08	2132.49	9.04813e+06	1429.55	9.84392e+07	1974.37	8.78598e+06	21988.1	912454	1.37579e+06	9.28802e+06	3.54939e+07
48238	20220802.1	6387.31	8.3497e+07	19188.9	1.6126e+07	5729.47	1.53396e+07	2569.69	1.00967e+07	1640.47	1.63975e+08	2124.47	9.04813e+06	1448.15	9.81771e+07	1981.95	8.78598e+06	18564.2	885044	1.36861e+06	9.22103e+06	3.58036e+07
48265	20220803.2	6621.25	8.3497e+07	20055.3	1.6126e+07	5687.13	1.50774e+07	2574.47	1.00967e+07	1652.14	1.62927e+08	2165.88	9.04813e+06	1467.62	9.81771e+07	1980.28	8.78598e+06	20935.2	890933	1.35601e+06	9.24179e+06	3.57417e+07
48306	20220804.2	6489.41	8.32349e+07	20751.6	1.66503e+07	5660.79	1.50774e+07	2529.32	9.83456e+06	1660.72	1.62927e+08	2133.96	9.04813e+06	1479.7	9.84392e+07	1944.3	8.52384e+06	19729.7	905665	1.37062e+06	9.28369e+06	3.55556e+07
48373	20220805.2	6557.04	8.37592e+07	20495.7	1.58639e+07	5629.8	1.56017e+07	2562.96	1.00967e+07	1653.14	1.63975e+08	2071.34	1.27181e+07	1465.79	9.84392e+07	1929.49	8.78598e+06	22403	902911	1.3655e+06	9.40304e+06	3.58663e+07
48404	20220808.3	6594.18	8.3497e+07	20746.5	1.58639e+07	5730.33	1.56017e+07	2554.05	1.00967e+07	1653.01	1.61092e+08	2084.8	9.04813e+06	1457.44	9.79149e+07	1985.4	8.78598e+06	18123.7	903389	1.34629e+06	9.20441e+06	3.58669e+07
48454	20220809.3	6515.24	8.37592e+07	20418.3	1.63882e+07	5601.53	1.50774e+07	2576.97	1.00967e+07	1654.72	1.62927e+08	2122.51	9.04813e+06	1457.02	9.66042e+07	1942.25	8.78598e+06	20203.4	901482	1.36025e+06	9.18382e+06	3.58669e+07
48471	20220810.2	7591.18	8.3497e+07	20542.1	1.58639e+07	5665.35	1.53396e+07	2572.87	9.83456e+06	1565.88	1.62402e+08	2147.39	9.04813e+06	1457.52	9.81771e+07	1991.34	8.78598e+06	18872.1	885309	1.37884e+06	9.10619e+06	3.58042e+07
48517	20220812.2	6524.52	8.42835e+07	20855.6	1.58639e+07	5815.75	1.56017e+07	2479.16	1.00967e+07	1637.24	1.63713e+08	2117.2	9.04813e+06	1464.36	9.81771e+07	1926.76	8.78598e+06	19935.4	902156	1.35709e+06	9.22099e+06	3.58669e+07
48563	20220815.3	5764.36	8.40213e+07	20751.2	1.6126e+07	5690.95	1.56017e+07	2537.98	1.00967e+07	1642.95	1.6083e+08	2116.06	9.04813e+06	1434.44	9.79149e+07	2014.3	8.78598e+06	22917	894200	1.35574e+06	9.20855e+06	3.58663e+07

backport/release/2.x/pr-4075

build_id	build_number	tpcc_sgx_cft^	tpcc_sgx_cft_mem	ls_sgx_cft^	ls_sgx_cft_mem	ls_jwt_sgx_cft^	ls_jwt_sgx_cft_mem	ls_js_sgx_cft^	ls_js_sgx_cft_mem	ls_v8_sgx_cft^	ls_v8_sgx_cft_mem	ls_full_js_sgx_cft^	ls_full_js_sgx_cft_mem	ls_full_v8_sgx_cft^	ls_full_v8_sgx_cft_mem	ls_js_jwt_sgx_cft^	ls_js_jwt_sgx_cft_mem	hist_sgx_cft^	RB put (/s)^	CHAMP put (/s)^	RB get (/s)^	CHAMP get (/s)^
48258	20220802.9	6519.15	8.37592e+07	20730.4	1.69124e+07	5633.36	1.50774e+07	2458.1	1.21939e+07	1652.39	1.62927e+08	2205.09	9.04813e+06	1453.96	9.79149e+07	1938.41	1.03588e+07	21033.6	906864	1.35011e+06	9.2501e+06	3.5128e+07
48270	20220803.4	6566.91	8.42835e+07	20660.1	1.58639e+07	5662.15	1.53396e+07	2555.49	1.00967e+07	1667.72	1.61092e+08	2128.98	9.04813e+06	1448.23	9.71285e+07	1991.37	8.78598e+06	20379.5	875470	1.34878e+06	9.27948e+06	3.50679e+07
48591	20220815.16	6354.97	8.45456e+07	20319.4	1.69124e+07	5700.18	1.56017e+07	2551.31	1.00967e+07	1610.54	1.63451e+08	2160.84	9.04813e+06	1414.03	9.84392e+07	1974.68	8.52384e+06	20928.7	899503	1.37828e+06	9.31328e+06	3.59298e+07

[eddyashton]

• Incorporate Fix failures in multi-threaded indexing unit tests #4117 in here.

[eddyashton]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).