Fix failures in multi-threaded indexing unit tests#4117
Merged
MahatiC merged 6 commits intomicrosoft:mainfrom Aug 12, 2022
Merged
Fix failures in multi-threaded indexing unit tests#4117MahatiC merged 6 commits intomicrosoft:mainfrom
MahatiC merged 6 commits intomicrosoft:mainfrom
Conversation
|
indexing_unit_test_deadlock@48512 aka 20220811.12 vs main ewma over 20 builds from 48248 to 48499 Click to see tablemain
indexing_unit_test_deadlock
|
achamayou
approved these changes
Aug 11, 2022
MahatiC
reviewed
Aug 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4100.
Temporary Draft while I throw the CI at itI believe I've fixed the issues in both tests that were leading to failures (aggressive backoff sometimes backing off too far, and unlucky timing ending a necessary tick before the polls had even started executing).