-
Notifications
You must be signed in to change notification settings - Fork 153
Fix regression tests (Analyze1FromSourcesV40) #151
Conversation
|
I'm going to merge this stuff. Any objections? @tom-englert, @sharwell |
|
I will rebase this as soon as the others are merged. |
|
I assume that the fix was rebased. If there is no objections I'll merge the PR. |
|
@SergeyTeplyakov No, this pull request is still waiting for #152, #153, and #154 to be merged. |
|
👍 We'll take a look at updating this now 😄 |
|
Rebased, ready to pull 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❗ Please revert this header change (and any like it).
Edit: This is part of the first three formatting commits which can simply be dropped from this pull request. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the two lines header is the correct one?
|
❗ Can you rebase this to not include the first three commits? |
Signed-off-by: tom-englert <mail@tom-englert.de>
…ad to InvariantCulture, so everything behaves the same as in the US. Signed-off-by: tom-englert <mail@tom-englert.de>
|
OK, just committed the functional changes. |
|
Changes to fix the tests look fine. I would prefer to separate the culture change to its own pull request, but I'll leave the call up to @SergeyTeplyakov. Overall 👍. |
|
p.s. there is already an issue to make string-formatting culture-independent: #149 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file causes ClousotTests not to show in Test Explorer, because it contains methods declared extern.
Error loading C:\…\CodeContracts\Microsoft.Research\RegressionTest\ClousotTests\bin\Debug\ClousotTests.dll: Unable to load the test container 'C:\…\CodeContracts\Microsoft.Research\RegressionTest\ClousotTests\bin\Debug\ClousotTests.dll' or one of its dependencies. Error details:
System.TypeLoadException: Could not load type 'TestPostconditionInference.FilterRedundantPostcondition' from assembly 'ClousotTests, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' because the method 'GetApplicationVersion' has no implementation (no RVA).
System.TypeLoadException: Could not load type 'TestPostconditionInference.Array' from assembly 'ClousotTests, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' because the method 'get_Length' has no implementation (no RVA).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sharwell I prefer separate PR, but separate commits are fine for now.
@tom-englert What do you think about @panacekcz comment? We can fix this in separate commit/PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These files should have been added as <None>, not as <Compile>.
It's only to have the test files part of the project.
Fix regression tests (Analyze1FromSourcesV40)
Fix the Analyze1FromSourcesV40 regression tests. (for #148)
Should not be pulled before #152, #153 and #154