Skip to content
This repository was archived by the owner on Jul 15, 2023. It is now read-only.

Conversation

@sharwell
Copy link
Contributor

This reformat operation used dotnet/codeformatter@1d719e4e with /rule-:FieldNames. In addition, two other changes were made:

  1. Use Tests.cs instead of v.cs (the former is exactly equivalent to the latter aside from including one additional disabled test).
  2. Add the remaining test sources to the project.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I saw that in some other PRs with formatting changes you also changed field names...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I explicitly disabled that - I left a message in Gitter explaining why (basically there is so much code to reformat that we need to do the safe option first and then we can consider renaming things in the future).

I closed all the other formatting PRs so I can update them to also not rename fields.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Jut wanted to double check.

This reformat operation used dotnet/codeformatter@1d719e4e with
/rule-:FieldNames.
@sharwell sharwell mentioned this pull request Jul 20, 2015
SergeyTeplyakov added a commit that referenced this pull request Aug 12, 2015
@SergeyTeplyakov SergeyTeplyakov merged commit 650120a into microsoft:master Aug 12, 2015
@sharwell sharwell deleted the format-clousottests branch August 12, 2015 20:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants