Skip to content

Comments

Add double click option for opening a grid row. Prevents opening a Lo…#746

Merged
TYLEROL merged 2 commits intomicrosoft:developfrom
rswafford:develop
Feb 6, 2020
Merged

Add double click option for opening a grid row. Prevents opening a Lo…#746
TYLEROL merged 2 commits intomicrosoft:developfrom
rswafford:develop

Conversation

@rswafford
Copy link

@rswafford rswafford commented Feb 3, 2020

…okup field instead.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (updates to documentation, formatting, etc.)

Description

Changed the code to always look for a div tag, and if selecting a record is called for, checking the box - otherwise, double click the row to open it.

Issues addressed

Open Record method was clicking on a Lookup link and opening the linked (parent) record rather than opening the record represented by the grid row.

Fixes: #655

All submissions:

  • My code follows the code style of this project.
  • Do existing samples that are effected by this change still run?
  • I have added samples for new functionality.
  • I raise detailed error messages when possible.
  • My code does not rely on labels that have the option to be hidden.

Which browsers was this tested on?

  • Chrome
  • Firefox
  • IE
  • Edge

@rswafford rswafford requested a review from TYLEROL February 4, 2020 16:07
@msftclas
Copy link

msftclas commented Feb 5, 2020

CLA assistant check
All CLA requirements met.

@TYLEROL TYLEROL added the bug label Feb 6, 2020
@TYLEROL TYLEROL added this to the 9.1.0.12013 milestone Feb 6, 2020
}
else
{
driver.DoubleClick(row.FindElement(By.TagName(tag)));
Copy link
Contributor

@AngelRodriguez8008 AngelRodriguez8008 Feb 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This double click is not working for me. Tested in Chrome v9.1 online.
test sample: UCITestAccountAddAppointment -> xrmApp.Grid.OpenRecord(0);

I understand the intention but I will roll it back, until a better approach is found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Grid.OpenRecord(0) opening Link instead of Record from Grid

4 participants