Add double click option for opening a grid row. Prevents opening a Lo…#746
Merged
TYLEROL merged 2 commits intomicrosoft:developfrom Feb 6, 2020
Merged
Add double click option for opening a grid row. Prevents opening a Lo…#746TYLEROL merged 2 commits intomicrosoft:developfrom
TYLEROL merged 2 commits intomicrosoft:developfrom
Conversation
…okup field instead.
TYLEROL
approved these changes
Feb 6, 2020
12 tasks
| } | ||
| else | ||
| { | ||
| driver.DoubleClick(row.FindElement(By.TagName(tag))); |
Contributor
There was a problem hiding this comment.
This double click is not working for me. Tested in Chrome v9.1 online.
test sample: UCITestAccountAddAppointment -> xrmApp.Grid.OpenRecord(0);
I understand the intention but I will roll it back, until a better approach is found.
This was referenced Feb 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…okup field instead.
Type of change
Description
Changed the code to always look for a div tag, and if selecting a record is called for, checking the box - otherwise, double click the row to open it.
Issues addressed
Open Record method was clicking on a Lookup link and opening the linked (parent) record rather than opening the record represented by the grid row.
Fixes: #655
All submissions:
Which browsers was this tested on?