Fix Double Click on OpenRecord from Grid#754
Merged
TYLEROL merged 13 commits intomicrosoft:developfrom Feb 18, 2020
Merged
Conversation
AngelRodriguez8008
changed the title
Contributor
Author
|
Hi @rswafford, Sorry, can you review this update to the OpenRecord Method Thanks & br |
This was referenced Feb 10, 2020
This was referenced Feb 10, 2020
|
@AngelRodriguez8008 looks fine to me - thanks! |
dtu11
reviewed
Feb 10, 2020
Microsoft.Dynamics365.UIAutomation.Api.UCI/Elements/OnlineLogin.cs
Outdated
Show resolved
Hide resolved
dtu11
reviewed
Feb 10, 2020
...soft.Dynamics365.UIAutomation.Sample/UCI/BusinessProcessFlow/BusinessProcessFlowNextStage.cs
Show resolved
Hide resolved
| protected readonly SecureString _username = ConfigurationManager.AppSettings["OnlineUsername"]?.ToSecureString(); | ||
| protected readonly SecureString _password = ConfigurationManager.AppSettings["OnlinePassword"]?.ToSecureString(); | ||
| protected readonly SecureString _mfaSecrectKey = ConfigurationManager.AppSettings["MfaSecrectKey"]?.ToSecureString(); | ||
| protected readonly bool _usePrivateMode = Convert.ToBoolean(ConfigurationManager.AppSettings["UsePrivateMode"] ?? bool.TrueString); |
Contributor
Author
There was a problem hiding this comment.
This is not required, it happens already in TestSettings
… Demo Tests when Login intentional fail
This was referenced Feb 12, 2020
…er do not get closed (Fix previous Issue that was solved with driver.Throw <= remove this)
# Conflicts: # Microsoft.Dynamics365.UIAutomation.Api.UCI/WebClient.cs # Microsoft.Dynamics365.UIAutomation.Sample/UCI/Login/Login.cs
Microsoft.Dynamics365.UIAutomation.Browser/Extensions/SeleniumExtensions.cs
Show resolved
Hide resolved
Microsoft.Dynamics365.UIAutomation.Browser/Extensions/SeleniumExtensions.cs
Show resolved
Hide resolved
Contributor
Author
There was a problem hiding this comment.
Do not navigate to Sales Hub, Accounts by default
Contributor
Author
|
This is now remerged from develop |
12 tasks
TYLEROL
approved these changes
Feb 18, 2020
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
I finally find the way to Restore the logic implemented in #746. The problem was that depending on the frame factor (zoom, windows size, etc) the double click was performed in an empty div inside the first cell that avoid to open the record. Unfortunately there is not other div available to click on it. I needed to extend the DobleClick Method to be performed inside the element but in some position related to another given inner element, in this case outside of the "empty div".
Above, Below, LeftTo, RightTo are available
Update: Click should be also fixed or the 'Edit' Button will not shown, eben the record is selected see test UCITestHighlightActiveAccount
Minor fixes in others sample tests UCITestAssignAccount & add UCITestAssignAccount_ToMe
Issues addressed
#655, #746
Related to #731. trying to fix all tests in an uncustomized environment.
All submissions:
Which browsers was this tested on?