Users/angel/fix samples fix login#760
Merged
TYLEROL merged 5 commits intomicrosoft:developfrom Feb 17, 2020
Merged
Conversation
Contributor
Author
AngelRodriguez8008
left a comment
AngelRodriguez8008
left a comment
There was a problem hiding this comment.
Hi @dtu11, I hope this is fine now. Thanks
| { | ||
| var message = $"An Error occur entering OTC. Exception: {e.Message}"; | ||
| Trace.TraceInformation(message); | ||
| throw driver.Throw<InvalidOperationException>(message, e); |
Contributor
Author
There was a problem hiding this comment.
the Loop logic was moved to the caller context
| driver.Quit(); | ||
| return (T) Activator.CreateInstance(typeof(T), message, innerException); | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
An Exception in Login Methods do left the Browser open (strange but true), calling this methods to throw the Exception solve this problem. See my comment hier
Contributor
Author
AngelRodriguez8008
left a comment
AngelRodriguez8008
left a comment
There was a problem hiding this comment.
now smaller
TYLEROL
approved these changes
Feb 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Fix #752 (splited branch from #754)
Issues addressed
Login is performed now but after Login method is hang on EnterOneTimeCode(driver, mfaSecrectKey); command inside Login method. see more
All submissions:
Which browsers was this tested on?