Revert unintended change to GSL_SUPPRESS #1226
Conversation
PR microsoft#1213 changed this line. According to https://github.com/microsoft/GSL/pull/1213/files#r2586073058 the change was unintended. This PR reverts the change to the previous implementation.
| #if defined(__clang__) | ||
| #define GSL_SUPPRESS(x) [[gsl::suppress(#x)]] | ||
| #elif defined(_MSC_VER) && _MSC_VER >= 1950 | ||
| // Visual Studio versions after 2022 (_MSC_VER > 1944) support the justification message. |
There was a problem hiding this comment.
The comment and check above it are not true.
This is mostly a note for me, feel free to punt this and I will take care of populating the correct information.
There was a problem hiding this comment.
Also, the motivation for this change has nothing to do with the justification message and everything to do with the warning for using gsl::suppress(x) instead of gsl::suppress("x").
There was a problem hiding this comment.
As the PR is still open and not merged: do you want me to do or change something?
If you tell me what to change, I can do so. Best might be if you add a comment with a suggestion that can directly be applied here in the web UI. But maybe it is better if you change the check to whatever is right in another PR?
|
These changes look good to me! Thanks! |
PR #1213 changed this line. According to https://github.com/microsoft/GSL/pull/1213/files#r2586073058 the change was unintended. This PR reverts the change to the previous implementation. Co-authored-by: Werner Henze <w.henze@avm.de>
2 participants
PR #1213 changed this line. According to https://github.com/microsoft/GSL/pull/1213/files#r2586073058 the change was unintended. This PR reverts the line to the previous implementation.