Skip to content

Revert unintended change to GSL_SUPPRESS #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carsonRadtke merged 1 commit into from
Dec 4, 2025
Merged

Revert unintended change to GSL_SUPPRESS #1226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/gsl/assert
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
// Visual Studio versions after 2022 (_MSC_VER > 1944) support the justification message.
Copy link
Member

@carsonRadtke carsonRadtke Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment and check above it are not true.

This is mostly a note for me, feel free to punt this and I will take care of populating the correct information.

Copy link
Member

@carsonRadtke carsonRadtke Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the motivation for this change has nothing to do with the justification message and everything to do with the warning for using gsl::suppress(x) instead of gsl::suppress("x").

Copy link
Contributor Author

@beinhaerter beinhaerter Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the PR is still open and not merged: do you want me to do or change something?

If you tell me what to change, I can do so. Best might be if you add a comment with a suggestion that can directly be applied here in the web UI. But maybe it is better if you change the check to whatever is right in another PR?

Copy link
Member

@carsonRadtke carsonRadtke Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take care of it.

#define GSL_SUPPRESS(x) [[gsl::suppress(#x)]]
#elif defined(_MSC_VER) && !defined(__INTEL_COMPILER) && !defined(__NVCC__)
#define GSL_SUPPRESS(x) [[gsl::suppress(#x)]]
#define GSL_SUPPRESS(x) [[gsl::suppress(x)]]
#else
#define GSL_SUPPRESS(x)
#endif // defined(__clang__)
Expand Down