-
Notifications
You must be signed in to change notification settings - Fork 760
Fixed unittest directory check to look in the source directory #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
annagrin
wants to merge
1
commit into
microsoft:master
from
annagrin:dev/annagrin/FixUnittestDirectoryCheck
Closed
Fixed unittest directory check to look in the source directory #2
annagrin
wants to merge
1
commit into
microsoft:master
from
annagrin:dev/annagrin/FixUnittestDirectoryCheck
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilmacintosh
pushed a commit
that referenced
this pull request
Dec 9, 2015
Update from Microsoft/GSL
clrxbl
added a commit
to clrxbl/GSL
that referenced
this pull request
Oct 8, 2018
Test project /GSL
Start 1: span_tests
1/15 Test microsoft#1: span_tests ....................... Passed 0.01 sec
Start 2: multi_span_tests
2/15 Test microsoft#2: multi_span_tests ................. Passed 0.02 sec
Start 3: strided_span_tests
3/15 Test microsoft#3: strided_span_tests ............... Passed 0.01 sec
Start 4: string_span_tests
4/15 Test microsoft#4: string_span_tests ................ Passed 0.01 sec
Start 5: at_tests
5/15 Test microsoft#5: at_tests ......................... Passed 0.00 sec
Start 6: bounds_tests
6/15 Test microsoft#6: bounds_tests ..................... Passed 0.01 sec
Start 7: notnull_tests
7/15 Test microsoft#7: notnull_tests .................... Passed 0.01 sec
Start 8: assertion_tests
8/15 Test microsoft#8: assertion_tests .................. Passed 0.01 sec
Start 9: utils_tests
9/15 Test microsoft#9: utils_tests ...................... Passed 0.01 sec
Start 10: owner_tests
10/15 Test microsoft#10: owner_tests ...................... Passed 0.00 sec
Start 11: byte_tests
11/15 Test microsoft#11: byte_tests ....................... Passed 0.01 sec
Start 12: algorithm_tests
12/15 Test microsoft#12: algorithm_tests .................. Passed 0.00 sec
Start 13: sloppy_notnull_tests
13/15 Test microsoft#13: sloppy_notnull_tests ............. Passed 0.00 sec
Start 14: no_exception_throw_tests
14/15 Test microsoft#14: no_exception_throw_tests ......... Passed 0.00 sec
Start 15: no_exception_ensure_tests
15/15 Test microsoft#15: no_exception_ensure_tests ........ Passed 0.00 sec
100% tests passed, 0 tests failed out of 15
Total Test time (real) = 0.11 sec
Arch Linux w/ Clang 3.12.3
JordanMaples
added a commit
that referenced
this pull request
Oct 25, 2019
updating personal branch.
dmitrykobets-msft
added a commit
to dmitrykobets-msft/GSL
that referenced
this pull request
Jan 28, 2022
GerHobbelt
pushed a commit
to GerHobbelt/GSL
that referenced
this pull request
Mar 20, 2024
build: fix conan packaging of include files
carsonRadtke
added a commit
that referenced
this pull request
Dec 5, 2025
carsonRadtke
added a commit
that referenced
this pull request
Dec 5, 2025
* infra: individual test executables We used have tests contained in a single executable. This was fine for testing, but it would be more convient to separate tests into indivudal modules so targeted changes could have targeted tests. This change associates each test file with its own executable. We now have 14 tests for GSL each of which testing a different component. * revert -Wno-reserved-identifier * Update tests/span_tests.cpp thanks copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * be sure to include build type in ctest command * [VS] make sure we are building the correct configuration * restore tests/span_tests.cpp * fix build break after merge conflicts * fix build break after merge conflicts #2 * another try at fixing a build break * fix silly typo. build break pt 4 * Use file globbing for test sources instead of manual list (#1227) * Initial plan * Use file globbing for test sources instead of manual list Replace the manually maintained list of test sources with file(GLOB) to automatically discover all .cpp files in the tests directory, excluding no_exception_ensure_tests.cpp which needs special compilation flags. This approach: - Automatically picks up new test files without CMake updates - Still correctly excludes no_exception_ensure_tests.cpp - Maintains the same test build configuration - Works with both C++14 and C++20 Co-authored-by: carsonRadtke <10507970+carsonRadtke@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: carsonRadtke <10507970+carsonRadtke@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The relative path in the original check caused cmake to look in the binary directory sometimes.