Dev/annagrin/strided array view bugfixes#7
Merged
neilmacintosh merged 13 commits intomicrosoft:masterfrom Sep 15, 2015
annagrin:dev/annagrin/strided_array_view_bugfixes
Merged
Dev/annagrin/strided array view bugfixes#7neilmacintosh merged 13 commits intomicrosoft:masterfrom annagrin:dev/annagrin/strided_array_view_bugfixes
neilmacintosh merged 13 commits intomicrosoft:masterfrom
annagrin:dev/annagrin/strided_array_view_bugfixes
Conversation
…w_bugfixes' into dev/annagrin/strided_array_view_bugfixes Conflicts: include/array_view.h
…iew_bugfixes Added support for all compiler and platform targets.
Contributor
|
Great set of changes Anna! |
neilmacintosh
pushed a commit
that referenced
this pull request
Sep 15, 2015
…ugfixes Fixes to strided_array_view and related classes.
clrxbl
added a commit
to clrxbl/GSL
that referenced
this pull request
Oct 8, 2018
Test project /GSL
Start 1: span_tests
1/15 Test microsoft#1: span_tests ....................... Passed 0.01 sec
Start 2: multi_span_tests
2/15 Test microsoft#2: multi_span_tests ................. Passed 0.02 sec
Start 3: strided_span_tests
3/15 Test microsoft#3: strided_span_tests ............... Passed 0.01 sec
Start 4: string_span_tests
4/15 Test microsoft#4: string_span_tests ................ Passed 0.01 sec
Start 5: at_tests
5/15 Test microsoft#5: at_tests ......................... Passed 0.00 sec
Start 6: bounds_tests
6/15 Test microsoft#6: bounds_tests ..................... Passed 0.01 sec
Start 7: notnull_tests
7/15 Test microsoft#7: notnull_tests .................... Passed 0.01 sec
Start 8: assertion_tests
8/15 Test microsoft#8: assertion_tests .................. Passed 0.01 sec
Start 9: utils_tests
9/15 Test microsoft#9: utils_tests ...................... Passed 0.01 sec
Start 10: owner_tests
10/15 Test microsoft#10: owner_tests ...................... Passed 0.00 sec
Start 11: byte_tests
11/15 Test microsoft#11: byte_tests ....................... Passed 0.01 sec
Start 12: algorithm_tests
12/15 Test microsoft#12: algorithm_tests .................. Passed 0.00 sec
Start 13: sloppy_notnull_tests
13/15 Test microsoft#13: sloppy_notnull_tests ............. Passed 0.00 sec
Start 14: no_exception_throw_tests
14/15 Test microsoft#14: no_exception_throw_tests ......... Passed 0.00 sec
Start 15: no_exception_ensure_tests
15/15 Test microsoft#15: no_exception_ensure_tests ........ Passed 0.00 sec
100% tests passed, 0 tests failed out of 15
Total Test time (real) = 0.11 sec
Arch Linux w/ Clang 3.12.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed incorrect size computation in strided_bounds
Fixed compilation issue in strided_array_view iterator
Added tests for strided array view iteration and size
Added stride() function to strided_bounds to support slicing
Fixed incorrect bounds check in basic_array_view operator[]
Made slicing work for 3+ dimensions
•made stride_array slice correctly by shifting its extents and strides to the left
•added shift functionality to index for better slicing performance
•added tests for 3d arrays
•added tests for iterations over statically and dynamically allocated arrays
Added type conversion for strided_arrays
Made original srided_array_view tests work with the new version
Added tests for misuse of strided array type conversion
Added error messages on fail_fast
Made strided_array_view constructor from array_view take bounds instead of index
Added bounds and resize checks, updated tests
Exposed iterator types from array_view and strided_array_view
Added tests for accessing and iterating over empty array_views and strided_array_views