Skip to content

Conversation

@chrisfromwork
Copy link
Contributor

@chrisfromwork chrisfromwork commented Dec 20, 2019

These changes are related to unblocking MSB4U usage in the MixedReality-SpectatorView repo.

  1. Asset retargeting appears to have been written originally with the mixed reality toolkit in mind. This change removes some toolkit specific paths. However, this fix does not solve things for asmdefs that don't have a Microsoft.MixedReality* prefix.
  2. A RegenerateSDKProjects function has been added that can be called from the command line. GenerateSDKProjects seems to run indefinitely when called from a cmd window.

@chrisfromwork chrisfromwork changed the title Included are some small fixes related to editor only files and non MRTK projects Small fixes related to editor only scripts and non MRTK projects Dec 20, 2019
@chrisfromwork chrisfromwork mentioned this pull request Jan 2, 2020
Uri dependencies = new Uri(Path.Combine(Utilities.AssetPath, "Dependencies\\"));
foreach (PluginAssemblyInfo plugin in Plugins.Where(t => t.Type != PluginType.Native))
{
Debug.Log($"Plugin: {plugin.Name} {plugin.Type} {plugin.AutoReferenced} {plugin.ReferencePath}");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this and the log below?

Copy link
Contributor

@andreiborodin andreiborodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on minor change.

@andreiborodin andreiborodin self-assigned this Jan 7, 2020
@andreiborodin andreiborodin added the bug Something isn't working label Jan 7, 2020
@andreiborodin andreiborodin added this to the 0.9.0 Release milestone Jan 7, 2020
Copy link
Contributor

@andreiborodin andreiborodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@andreiborodin andreiborodin merged commit 1c396d4 into microsoft:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants