This repository was archived by the owner on Jun 14, 2024. It is now read-only.
Remove qr code preprocessor directive #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisfromwork
requested review from
andreiborodin,
fiban-havok,
ivte-ms,
matthejo,
stkenned-havok and
wiwei
fiban-havok
reviewed
Jan 6, 2020
fiban-havok
reviewed
Jan 6, 2020
fiban-havok
approved these changes
Jan 7, 2020
matthejo
reviewed
Jan 7, 2020
| assetBundleVariant: | ||
| script: {fileID: 11500000, guid: 0e4dca1acba66fd478b3854f09a32ec7, type: 3} | ||
| buildEngine: 0 | ||
| profiles: [] |
Contributor
There was a problem hiding this comment.
Should these new meta files exist? Seems like something that might be missing from the .gitignore since I don't see the corresponding files, just the meta files.
Contributor
Author
There was a problem hiding this comment.
I'm not sure what the call is on this. I'll ask andrei today.
Contributor
Author
There was a problem hiding this comment.
we want to include these files, there may be something wrong if we aren't including csprojs .I will follow up in a different review.
added 12 commits
January 8, 2020 13:02
…m/chrisfromwork/MixedReality-SpectatorView into removeQRCodePreprocessorDirective
…ectatorView into removeQRCodePreprocessorDirective
chrisfromwork
added
the
breaking change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please view #308 before this pull request.
This review includes the following changes:
Note: this change requires the following change in the MSBuildForUnity repo: microsoft/MSBuildForUnity#94
Breaking Change Details
Notes:
With this change, folks no longer have to set a preprocessor directive include the QR Code Plugin binary. This means that codes will always need the QR Code Plugin dll for things to compile. Therefore, we are now distributing the QR Code Plugin with the main spectator view codebase and folks will need to delete any MixedReality-QRCodePlugin symbolic links from existing projects.
Migration Instructions: