[PTRun]Fix accent on title bar bleed into UI#33046
Merged
jaimecbernardo merged 2 commits intomainfrom May 26, 2024
Merged
Conversation
stefansjfw
approved these changes
May 24, 2024
Contributor
stefansjfw
left a comment
stefansjfw
left a comment
There was a problem hiding this comment.
Glitch is visible, but overall behavior is better. LGTM
Contributor
Author
|
The glitch is that title bar accent is still getting shown for some frames while the PTRun window is drawing. But behavior is at least better. |
jaimecbernardo
added
the
Hot Fix
jaimecbernardo
added a commit
that referenced
this pull request
Jun 20, 2024
This reverts commit 8bb5a33.
11 tasks
jaimecbernardo
added a commit
that referenced
this pull request
Jun 21, 2024
…33458) * Revert "[PTRun]Fix accent on title bar bleed into UI (#33046)" This reverts commit 8bb5a33. * Revert "[PTRun]Use Mica backdrop to fix crashes with WPFUI (#32118)" This reverts commit b9da1e6. * Fix DWMAttributes in Wox Plugin Native Methods * Fix titlebar accent showing * Fix number on wrong enum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
There's this option on Windows, called "Show accent color on title bars and windows borders":
It makes PowerToys Run look like this:
WPF UI doesn't seem to give much tools in terms of overriding that, so we make the search box opaque instead:
PR Checklist