[PTRun]Bring back acrylic and proper fix to title bar accent showing#33458
[PTRun]Bring back acrylic and proper fix to title bar accent showing#33458jaimecbernardo merged 5 commits intomainfrom
Conversation
| BorderColor = 34, | ||
| CaptionColor = 35, | ||
| TextColor = 36, | ||
| VisibleFrameBorderThickness, |
There was a problem hiding this comment.
You're right! Thank you! Fixed!
| Cloak = 13, | ||
| Cloaked = 14, |
There was a problem hiding this comment.
Do we use a different enum in ww plugin? otherwise please verify that no dummy windows for uwp apps shown in results.
There was a problem hiding this comment.
ww plugin just puts 12 directly 😆
There was a problem hiding this comment.
For the cloak ones, the number is the same :) It starts with 1 and goes up is the default behavior, so the number will be kept.
There was a problem hiding this comment.
I was trying to use CaptionColor and that's when I saw this was wrong.
There was a problem hiding this comment.
ww plugin just puts 12 directly
No. See Components\Window.cs:L306
There was a problem hiding this comment.
I know :) Cloak and Cloaked get the same value due to the default +1 logic in enums. This just makes it explicit since not every value follows that logic
There was a problem hiding this comment.
My mistake. Thought the counter changes +1 for the first enum item. But the first two have a very similar name. 🙃
| CaptionColor = 35, | ||
| TextColor = 36, | ||
| VisibleFrameBorderThickness = 37, | ||
| Last, |
There was a problem hiding this comment.
Let's leave that one without a number, so it's always +1 then the previous one. I think that's there just so we have a "stop" if we want to go in a loop 🤔 That was something that was usual to do in C code.
stefansjfw
left a comment
stefansjfw
left a comment
There was a problem hiding this comment.
works great! nice work!
After #33458 , that fix crashes on Windows 10, where the caption color attribute is not supported. This PR disables the fix on Windows 10, since it's not even needed there actually.
3 participants
Summary of the Pull Request
Recent UI changes in PowerToys Run made users unhappy with the looks of PowerToys Run. And those changes didn't properly fix the issues they were trying to solve.
This reverts #33046 and #32118
It brings back Acrylic backdrop.
It removes the opaque search bar background that was disliked by users.
It includes the fix in wpf ui for the title bar accent showing through: https://github.com/lepoco/wpfui/pull/1122/files#diff-196b404f4db09632665ef546da6c8e57302b2f3e3d082eb4b5c295ae3482d94a
If fixes PowerToys Run becoming opaque after a theme change too.
It also fixes the Wox Plugin DWM Attributes enum, since the values were wrong. Used this as a base to update the values: https://groups.google.com/g/golang-codereviews/c/C06XsvvpNPo?pli=1
PR Checklist
Validation Steps Performed
Set up the accent color to show in windows title bar:
After that, verified the tile bar didn't appear in PowerToys Run, as specified in #30206
Also changed theme a couple of times to verify it still looked good with some transparency.