[PTRun]Disable titlebar accent workaround on Windows 10#33505
Merged
jaimecbernardo merged 2 commits intomainfrom Jun 25, 2024
Merged
[PTRun]Disable titlebar accent workaround on Windows 10#33505jaimecbernardo merged 2 commits intomainfrom
jaimecbernardo merged 2 commits intomainfrom
Conversation
gokcekantarci
approved these changes
Jun 25, 2024
Contributor
gokcekantarci
left a comment
gokcekantarci
left a comment
There was a problem hiding this comment.
Tested with win10 and VM win11. LGTM!!
htcfreek
reviewed
Jun 25, 2024
| // https://github.com/lepoco/wpfui/pull/1122/files#diff-196b404f4db09632665ef546da6c8e57302b2f3e3d082eb4b5c295ae3482d94a | ||
| IntPtr windowHandle = new WindowInteropHelper(window).Handle; | ||
| if (windowHandle == IntPtr.Zero) | ||
| if (OSVersionHelper.IsWindows11()) |
Collaborator
There was a problem hiding this comment.
Do we need a comment why this is only on Win11?
Contributor
Author
There was a problem hiding this comment.
I can add it :)
Contributor
Author
There was a problem hiding this comment.
I've added a comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
After #33458 , that fix crashes on Windows 10, where the caption color attribute is not supported.
This PR disables the fix on Windows 10, since it's not even needed there actually.
Fixes: #33504