Conversation
Closed
Contributor
|
@peendebak a bunch of the code around this is changing in #159 - do you mind if we wait until that is merged and we can insert all the functionality of #167 in the updated framework? |
Contributor
Author
|
@alexcjohnson Waiting a little is fine with me. Maybe a more generic form of the functionality could be implemented in #159 already? In this PR I pass on |
|
|
||
| def get_attribute(self, name): | ||
| ''' Get an attribute from the model (server side) ''' | ||
| return self.ask('_magicget:%s' % (name, )) |
|
Issues
======
- Added 5
Complexity increasing per file
==============================
- qcodes/instrument/mock.py 2
See the complete overview on Codacy |
| def call_function(self, name, *args): | ||
| ''' Call a function from the model (server side) ''' | ||
| return self.ask('_magiccall:%s' % (name, ), *args) | ||
|
|
Contributor
|
replaced by #261 (and mooted anyway) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
get_attributeto theMockModel. A correspondingset_attributeshould be implemented.