Skip to content

feature: Add NestedAttrAccess support to MockModel#261

Merged
alexcjohnson merged 2 commits intomasterfrom
feat/mockmodel-attrs
Jul 25, 2016
Merged

feature: Add NestedAttrAccess support to MockModel#261
alexcjohnson merged 2 commits intomasterfrom
feat/mockmodel-attrs

Conversation

@alexcjohnson
Copy link
Contributor

@peendebak This is intended to replace #183 - providing access to objects in the MockModel server process using the NestedAttrAccess framework that we already have for instrument servers.

@qcodes-bot
Copy link

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 1


Clones added
============
- qcodes/tests/test_instrument.py  2

See the complete overview on Codacy


from .base import Instrument
from qcodes.process.server import ServerManager, BaseServer
from qcodes.utils.nested_attrs import NestedAttrAccess, _NoDefault

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexcjohnson
Copy link
Contributor Author

@peendebak Does this solve #84 ?

@eendebakpt
Copy link
Contributor

@alexcjohnson I am not sure this is important any more. I will convert my simulation to do without the MockXXX objects. Also the fixing of multiprocessing will introduce new proxy objects, so they might automatically have access to attributes.

@alexcjohnson
Copy link
Contributor Author

@eendebakpt good point - it's possible we'll get rid of MockInstrument entirely at some point. But until then this may still be useful (at least for development purposes) so I'll merge it in and close #84 .

@alexcjohnson alexcjohnson merged commit 2c5ac92 into master Jul 25, 2016
@alexcjohnson alexcjohnson deleted the feat/mockmodel-attrs branch July 25, 2016 10:30
This was referenced Jul 25, 2016
giulioungaretti pushed a commit that referenced this pull request Jul 25, 2016
Merge: 6baf12d b0c5aa4
Author: alexcjohnson <johnson.alex.c@gmail.com>

    Merge pull request #261 from qdev-dk/feat/mockmodel-attrs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants