This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Consolidate exact and approximate multiplexing logic. #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgranade
requested review from
ScottCarda-MS,
bettinaheim,
guanghaolow and
martinquantum
ScottCarda-MS
approved these changes
Dec 5, 2019
alexeib2
reviewed
Dec 9, 2019
alexeib2
left a comment
alexeib2
left a comment
There was a problem hiding this comment.
The changes/refactoring look good to me. The only thing I am curious about: where did ReflectAboutInteger code has gone? (I think you wrote about it the other day, but I forgot...)
Contributor
Author
|
Thanks for looking over! I didn't change anything about |
alexeib2
approved these changes
Dec 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates the new approximate multiplexing and state preparation logic introduced with the QML feature into the existing functionality provided by the standard library. As this is going into the QML feature branch (see #176), unit testing of the new approximate multiplexing logic has been temporarily deferred to the broader unit testing task in that draft PR.