Initial version of quantum machine learning library / QCC classifier #176

cgranade · 2019-11-15T01:00:03Z

This PR represents joint work with @alexeib2 on a new quantum machine learning library focused on the QCCC algorithm of Maria Schuld, Alex Bocharov, Krysta Svore, Nathan Wiebe ("Circuit-centric quantum classifiers", https://arxiv.org/abs/1804.00633).

Note that this PR is currently marked as draft, as work on this feature is in progress. Still to be done:

@alex

This PR represents joint with with @alex Bocharov, and begins open development on a quantum machine learning library.

cgranade · 2019-11-20T02:50:24Z

I've added one more TODO item to this draft PR to reflect that many operations have common inputs, but that appear in different order. The final API for this library should be uniform with respect to these choices to minimize user surprise.

…upport QML (#177) * Started writing unit tests for new standard library functionality. * Testing new array fn. * Fixes to Runtime project. * Added more tests. * Added tesets for rest of functionality added to M.Q.Std.

* Drafted new apply ops * Fixed docs * Fixed minor bugs * Added Permutation function + helper Arrays + Claim functions * Added Adj + Ctl and set csproj back to generating docs * Added tests * Fixed test errors * Updated code from comments; moved PermuteQubits to CommonGates * Fixed minor bugs * Apply suggestions from code review Co-Authored-By: Chris Granade <cgranade@gmail.com> * Added some fixes from changes * Added most recommendations from Mathias * Added example to ApplySeriesOfOps * Added new examples * Added PermuteQubits example * Changed Swap Order to be appending to an array, added test for it * Updated ApplyOpRepeatedlyOver Docs * Added Mathias' comments * Reverted csproj file * Renamed TupleArrayAsNestedArray

…nto feature/qml

@bettinaheim

* Removed unused "adapter" operations. * Removed unused operation. * Consolidated two APIs for estimating classification probabilities. * Removed old version of CircuitResult operation. * Simplified classification operation slightly. * Eliminated unused operation. * Clarified InferredLabel, updated argument order to respect currying. * Moved bias update into training, fixed bug. * Renamed operations to estimate classification probabilities. * Simplify TallyHitsMisses. * Trivial commit. * Addressing @bettinaheim's feedback.

* Added comments * Test case for new univariate optimizer. * Update to latest alpha. * Fix order of interval edges. * Fix parabola test. * Use new minimization to simplify training logic. * Used new optimization function to simplify bias search. * Revert to public alphas. * Temporarily revert use of Test attribute.

* Add placeholder for QML unit tests. * Add copyright header. * Trigger build on feature work.

* Consolidated exact and approximate MultiplexZ. * Consolidate exact and approx ApplyDiagonalUnitary * Finished consolidating multiplexers. * Code cleanup, inclusive language. * Whitespace fix and name clarification. * Consolidated arbitrary state preparation. * Slight cleanup. * API documentation comments.

* Clarify the restriction on the number of bits for IntAsBoolArray (#171) * Clarify the restriction on the number of bits for IntAsBoolArray This should fix #166 by providing a more specific error message. * Update Standard/src/Convert/Convert.qs Co-Authored-By: Chris Granade <chgranad@microsoft.com> * Allow to have bits = 0 Looks like our tests assume that number = 0 with bits = 0 is a valid scenario; updating the change to account for that * Package updates (#188) * Updated sourcelink on QML to match new version.

…187) * Begin simplifying training API. * Fix for TrainQcccSequential. * Simplify OneStochasticTrainingEpoch. * Simplified training API a little more. * Remove unused operation. * Started Chunks function. * Began removing ExtractMiniBatch. * Simplify training API with new SequentialModel UDT. * Further consolidate APIs. * Consolidated training and classification APIs further. * Fixed bug in Chunks. * Regression test for prev commit. * Make internal implementation of sequential model trainer private. * Make APIs more uniform. * Added new array function to simplify Misclassifications. * Remove ExtractMiniBatch. * Removed deprecated operations. * Fix type in Examples. * More progress removing private fns and ops from public API. * Further consolidated API surface. * Addressing feedback.

* Clarify the restriction on the number of bits for IntAsBoolArray (#171) * Clarify the restriction on the number of bits for IntAsBoolArray This should fix #166 by providing a more specific error message. * Update Standard/src/Convert/Convert.qs Co-Authored-By: Chris Granade <chgranad@microsoft.com> * Allow to have bits = 0 Looks like our tests assume that number = 0 with bits = 0 is a valid scenario; updating the change to account for that * Package updates (#188) * Quantum AND gates (a.k.a. CCNOT with constant target) (#186) * Two AND gate implementations. * Added test case. * Formatting. * Code formatting. * Update Standard/src/Canon/And.qs Co-Authored-By: Chris Granade <chgranad@microsoft.com> * Assertion for 0-target. * Added DOI to references. * Named application for CCNOTop. * Rename operations. * Add Test attribute. * Add links to arXiv. * Rename operations. * Better assertion for 0-target. * Fix bug in LowDepthAnd. * Docs. * Doc string convention. * Controlled variant for `ApplyAnd`. * Controlled AndLowDepth. * Adjoint Controlled LowDepthAnd. * References. * Simplify code. * Apply suggestions from code review Co-Authored-By: Chris Granade <chgranad@microsoft.com> * Integrate comment. * Removed comment ref to IncrementByIntegerPhaseLE (#189) There appears to be no function IncrementByIntegerPhaseLE, and I guess it is covered by ApplyLEOperationOnPhaseLE. Co-authored-by: Chris Granade <cgranade@gmail.com> * New Hadamard and SWAP test operations. (#196) * First work on Hadamard and SWAP test operations. * (c) header and typo fix. * Fixed typo with placement of phase shift. * Put public operations above private. * Added tests for new operations. * Added API documentation comments. * Newline at end of file. * Refactor AA namespace to use Q# style guide (#197) * Began simplifying AA interface. * Expose traditional AA as new public operation. * Removed rest of "AmpAmp" prefix. * Resolve deprecation warning. * Switching to using the new Sdk (#194) * Minor doc fixes (#190) * Minor doc fixes * Minor doc cleanup There are probably still some unstated assumptions on the algorithms. * Add "# Description" for MultiplyByModularInteger ...because there is inline math. Co-Authored-By: Chris Granade <cgranade@gmail.com> * "unitary operation" instead of "unitary operator" Co-Authored-By: Chris Granade <cgranade@gmail.com> * Add "# Description", remove refs in "# Summary" Co-authored-by: Chris Granade <cgranade@gmail.com> * Fix build by updating QML projects to use SDK. Co-authored-by: Mariia Mykhailova <michaylova@gmail.com> Co-authored-by: bettinaheim <34236215+bettinaheim@users.noreply.github.com> Co-authored-by: Mathias Soeken <mathias.soeken@gmail.com> Co-authored-by: numpde <21158052+numpde@users.noreply.github.com>

* Clarify the restriction on the number of bits for IntAsBoolArray (#171) * Clarify the restriction on the number of bits for IntAsBoolArray This should fix #166 by providing a more specific error message. * Update Standard/src/Convert/Convert.qs Co-Authored-By: Chris Granade <chgranad@microsoft.com> * Allow to have bits = 0 Looks like our tests assume that number = 0 with bits = 0 is a valid scenario; updating the change to account for that * Package updates (#188) * Quantum AND gates (a.k.a. CCNOT with constant target) (#186) * Two AND gate implementations. * Added test case. * Formatting. * Code formatting. * Update Standard/src/Canon/And.qs Co-Authored-By: Chris Granade <chgranad@microsoft.com> * Assertion for 0-target. * Added DOI to references. * Named application for CCNOTop. * Rename operations. * Add Test attribute. * Add links to arXiv. * Rename operations. * Better assertion for 0-target. * Fix bug in LowDepthAnd. * Docs. * Doc string convention. * Controlled variant for `ApplyAnd`. * Controlled AndLowDepth. * Adjoint Controlled LowDepthAnd. * References. * Simplify code. * Apply suggestions from code review Co-Authored-By: Chris Granade <chgranad@microsoft.com> * Integrate comment. * Removed comment ref to IncrementByIntegerPhaseLE (#189) There appears to be no function IncrementByIntegerPhaseLE, and I guess it is covered by ApplyLEOperationOnPhaseLE. Co-authored-by: Chris Granade <cgranade@gmail.com> * New Hadamard and SWAP test operations. (#196) * First work on Hadamard and SWAP test operations. * (c) header and typo fix. * Fixed typo with placement of phase shift. * Put public operations above private. * Added tests for new operations. * Added API documentation comments. * Newline at end of file. * Refactor AA namespace to use Q# style guide (#197) * Began simplifying AA interface. * Expose traditional AA as new public operation. * Removed rest of "AmpAmp" prefix. * Resolve deprecation warning. * Begin moving classifier structure creation to Q#. * Moving example datasets into new namespace. * Fix datasets used in layered structure demo. * Fixed bug with cyclic entangling layer. * Use new Hadamard test operation to simplify grad est. * Simplify input encoder logic. * Removed layer construction methods moved out to Q#. * Revised name of approximate input encoder. * Removed unused interop library. * Update pack script for new layout. * Addressing feedback. Co-authored-by: Mariia Mykhailova <michaylova@gmail.com> Co-authored-by: bettinaheim <34236215+bettinaheim@users.noreply.github.com> Co-authored-by: Mathias Soeken <mathias.soeken@gmail.com> Co-authored-by: numpde <21158052+numpde@users.noreply.github.com>

* Begin preparing for API review. * A bit more refactoring. * A bit more refactoring, more /// comments. * Progress on ///, code quality.

Merge master into QML feature

Fix path to pubkey for QML signing.

Co-Authored-By: Alan Geller <alan.geller@microsoft.com>

cgranade · 2020-02-11T23:37:16Z

This is currently blocked on #227, but is otherwise ready for merging to master, I think!

Update: No longer blocked, thanks for the review @tcNickolas!

Catch up QML to master.

ScottCarda-MS

Since everything in this PR seems to have passed through a previous PR, I didn't do much more than a cursory glance at the code, but nothing appeared to be out of place.

geduardo · 2020-02-14T19:07:22Z

My suggestion was wrong, nevermind!

bettinaheim

I commented the thoughts that occurred to me as I went over it. They accumulated... feel free to ignore any of them.

bettinaheim · 2020-02-20T21:23:43Z

MachineLearning.sln

+
+Microsoft Visual Studio Solution File, Format Version 12.00
+# Visual Studio 15
+VisualStudioVersion = 15.0.26124.0


This should just be overwritten if it's opened with VS19 I believe. It might still be worth it quickly doing that, since we no longer support VS17.

Sounds good. I generated this with dotnet new sln, didn't realize that it used an older version of the sln format.

MachineLearning/src/Datasets/IrisDataset.qs

MachineLearning/src/MachineLearning.csproj

bettinaheim · 2020-02-20T21:29:40Z

MachineLearning/src/MachineLearning.csproj

+    <ProjectReference Include="..\..\Standard\src\Standard.csproj" />
+  </ItemGroup>
+
+  <!-- Configure NuGet package metadata as well. -->


It might be worth setting up a common props file for most of these.

Fair point, yes. That said, I'd like to defer to a future PR.

MachineLearning/src/Structure.qs

MachineLearning/src/Training.qs

cgranade · 2020-02-21T05:11:29Z

Thanks for the feedback, @bettinaheim! Since this is a locked feature branch, I'll address your comments in a separate PR targeting this one, and will open that shortly. Thanks!

)

Chris Granade and others added 2 commits November 15, 2019 00:49

Merged PR 2339: Initial development on QML library.

7f62673

This PR represents joint with with @alex Bocharov, and begins open development on a quantum machine learning library.

Merge branch 'master' into feature/qml

cfb2ba4

cgranade mentioned this pull request Nov 15, 2019

Unit tests for new operations and functions in M.Q.Standard used to support QML #177

Merged

Chris Granade and others added 6 commits November 20, 2019 15:21

Merge branch 'master' into feature/qml

20529cf

Merge branch 'master' into feature/qml

3e0517d

Merge branch 'master' into feature/qml

3201cde

Merge branch 'feature/qml' of github.com:Microsoft/QuantumLibraries i…

7e4440a

…nto feature/qml

cgranade mentioned this pull request Nov 22, 2019

Begin samples for new QML library. microsoft/Quantum#270

Merged

cgranade and others added 3 commits November 22, 2019 15:25

Fix merge conflict.

22a3dd5

cgranade mentioned this pull request Dec 4, 2019

Consolidate exact and approximate multiplexing logic. #184

Merged

Chris Granade added 4 commits December 6, 2019 17:43

Add placeholder for QML unit tests. (#185)

0e3b5f9

* Add placeholder for QML unit tests. * Add copyright header. * Trigger build on feature work.

This was referenced Jan 2, 2020

Update QML feature to master. #198

Merged

Simplify gradient estimation and classifier structure generation #200

Merged

Chris Granade and others added 9 commits January 8, 2020 13:56

Final prep for QML review (#205)

a35aa5f

* Begin preparing for API review. * A bit more refactoring. * A bit more refactoring, more /// comments. * Progress on ///, code quality.

Merge branch 'master' into cgranade/master→qml

0ba2327

Merge pull request #208 from microsoft/cgranade/master→qml

680c52e

Merge master into QML feature

Fix path to pubkey for QML signing.

d8c4371

Merge pull request #213 from microsoft/cgranade/fix-qml-key

99ddbae

Fix path to pubkey for QML signing.

Update QML signing for new pipeline. (#217)

27cae56

Merge branch 'master' into final-qml-api

f1e9ade

cgranade and others added 8 commits February 5, 2020 14:53

More tests of structure functions.

1c85c75

Fixed test and eliminated some warnings.

fd0b40a

Further warning elimination.

748d129

Tests for InferredLabel and InferredLabels.

a387017

Undo printf-style debugging.

1039a0d

Update MachineLearning/tests/ClassificationTests.qs

d9ff816

Co-Authored-By: Alan Geller <alan.geller@microsoft.com>

Improve QML test coverage. (#224)

daec81b

Merge branch 'master' into master→qml

d2de0e0

cgranade marked this pull request as ready for review February 11, 2020 23:36

Merge pull request #227 from cgranade/master→qml

73a3686

Catch up QML to master.

cgranade requested review from alan-geller, anpaz, bettinaheim and tcNickolas February 12, 2020 00:59

ScottCarda-MS approved these changes Feb 12, 2020

View reviewed changes

Merge branch 'master' into feature/qml

3982206

bettinaheim approved these changes Feb 20, 2020

View reviewed changes

cgranade mentioned this pull request Feb 21, 2020

Addressing feedback from @bettinaheim. #233

Merged

Chris Granade and others added 7 commits February 21, 2020 10:28

Addressing feedback from @bettinaheim. (#233)

86712bd

Added new verbosemessage training option.

22e61d7

Cache state preparation using BoundCA.

61d5e4f

Merge branch 'feature/qml' into cgranade/use-udt-perf

1feae2d

Addressing @bettinaheim's feedback.

01dc4e1

Fix type of Ignore.

bdc04ba

Add verbose option to TrainingOptions UDT, cache state preparation (#234

df27b30

)

cgranade merged commit 2f510ae into master Feb 23, 2020

anpaz deleted the feature/qml branch July 24, 2020 19:41

Initial version of quantum machine learning library / QCC classifier #176

Initial version of quantum machine learning library / QCC classifier #176

Uh oh!

Conversation

cgranade commented Nov 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cgranade commented Nov 20, 2019

Uh oh!

cgranade commented Feb 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ScottCarda-MS left a comment

Choose a reason for hiding this comment

Uh oh!

geduardo commented Feb 14, 2020

Uh oh!

bettinaheim left a comment

Choose a reason for hiding this comment

Uh oh!

bettinaheim Feb 20, 2020

Choose a reason for hiding this comment

Uh oh!

cgranade Feb 21, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bettinaheim Feb 20, 2020

Choose a reason for hiding this comment

Uh oh!

cgranade Feb 21, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cgranade commented Feb 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cgranade commented Nov 15, 2019 •

edited

Loading

cgranade commented Feb 11, 2020 •

edited

Loading