This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Merge master into QML feature #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clarify the restriction on the number of bits for IntAsBoolArray This should fix #166 by providing a more specific error message. * Update Standard/src/Convert/Convert.qs Co-Authored-By: Chris Granade <chgranad@microsoft.com> * Allow to have bits = 0 Looks like our tests assume that number = 0 with bits = 0 is a valid scenario; updating the change to account for that
* Two AND gate implementations. * Added test case. * Formatting. * Code formatting. * Update Standard/src/Canon/And.qs Co-Authored-By: Chris Granade <chgranad@microsoft.com> * Assertion for 0-target. * Added DOI to references. * Named application for CCNOTop. * Rename operations. * Add Test attribute. * Add links to arXiv. * Rename operations. * Better assertion for 0-target. * Fix bug in LowDepthAnd. * Docs. * Doc string convention. * Controlled variant for `ApplyAnd`. * Controlled AndLowDepth. * Adjoint Controlled LowDepthAnd. * References. * Simplify code. * Apply suggestions from code review Co-Authored-By: Chris Granade <chgranad@microsoft.com> * Integrate comment.
There appears to be no function IncrementByIntegerPhaseLE, and I guess it is covered by ApplyLEOperationOnPhaseLE. Co-authored-by: Chris Granade <cgranade@gmail.com>
* First work on Hadamard and SWAP test operations. * (c) header and typo fix. * Fixed typo with placement of phase shift. * Put public operations above private. * Added tests for new operations. * Added API documentation comments. * Newline at end of file.
* Began simplifying AA interface. * Expose traditional AA as new public operation. * Removed rest of "AmpAmp" prefix. * Resolve deprecation warning.
* Minor doc fixes * Minor doc cleanup There are probably still some unstated assumptions on the algorithms. * Add "# Description" for MultiplyByModularInteger ...because there is inline math. Co-Authored-By: Chris Granade <cgranade@gmail.com> * "unitary operation" instead of "unitary operator" Co-Authored-By: Chris Granade <cgranade@gmail.com> * Add "# Description", remove refs in "# Summary" Co-authored-by: Chris Granade <cgranade@gmail.com>
* Improve code quality with experimental linter. * Fixed a couple mistakes in previous cleanup. * More fixes to resolve linting issues. * Remove extraneous comment. * Applied feedback from #198. * Applying more documentation fixes suggested by linter. * Fix to deprecation stub. * Whitespace fix noted by @ScottCarda-MS. * Fixed minor mistake introduced with previous code quality fix. * Incorporated more feedback from @ScottCarda-MS. * Update Standard/src/Arrays/Map.qs Co-Authored-By: Alan Geller <alan.geller@microsoft.com> * Update Standard/src/Canon/Combinators/ApplyIf.qs Co-Authored-By: Alan Geller <alan.geller@microsoft.com> * Update Standard/src/Canon/Combinators/ApplyIf.qs Co-Authored-By: Alan Geller <alan.geller@microsoft.com> * Update Standard/src/Canon/Combinators/ApplyIf.qs Co-Authored-By: Alan Geller <alan.geller@microsoft.com> * Update Standard/src/Arithmetic/Integer.qs Co-Authored-By: Alan Geller <alan.geller@microsoft.com> * Update Standard/src/Arithmetic/Integer.qs Co-Authored-By: Alan Geller <alan.geller@microsoft.com> * Update Standard/src/Canon/Combinators/ApplyIf.qs Co-Authored-By: Alan Geller <alan.geller@microsoft.com> * Update Standard/src/Arithmetic/Integer.qs Co-Authored-By: Alan Geller <alan.geller@microsoft.com> * Update Standard/src/Arithmetic/Integer.qs Co-Authored-By: Alan Geller <alan.geller@microsoft.com> * Update Standard/src/Arithmetic/Integer.qs Co-Authored-By: Alan Geller <alan.geller@microsoft.com> * Update Standard/src/Arithmetic/Integer.qs Co-Authored-By: Alan Geller <alan.geller@microsoft.com> * Addressing feedback, lots of indentation fixes. * Deprecate the stack data structure. * Slight improvements to phase est operations. * Add missing characteristics to CNOTChainTarget. * CCNOTChainTarget → ApplyCNOTChainWithTarget * Workaround for kata oracle counting. Co-authored-by: Alan Geller <alan.geller@microsoft.com>
Co-authored-by: Chris Granade <cgranade@gmail.com>
cgranade
requested review from
ScottCarda-MS,
anpaz,
bamarsha,
bettinaheim and
tcNickolas
anpaz
approved these changes
Jan 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates feature/qml to include recent changes on master. Please do not merge this PR as a squash merge; we'll need to keep commit history for the QML branch to remain ahead of master. Thank you!