This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Added initial pre-commit settings. #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgranade
requested review from
anpaz,
bettinaheim,
martinquantum,
tcNickolas and
thomashaener
cgranade
force-pushed
the
cgranade/pre-commit
branch
from
fc6e172 to
63f2b82
Compare
bettinaheim
approved these changes
Nov 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial support for using the
pre-commitlibrary to filter out extraneous noise from diffs, including trailing whitespace as well as mixed spaces and tabs. Using this configuration, contributors with the pre-commit hooks installed will be notified when they accidently commit mixed tabs and spaces, and will be offered an ammended commit with the issue rectified.