-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Labels
fixedSomething works now, yay!Something works now, yay!infrastructureRelated to repository automationRelated to repository automation
Description
Our automation to "validate" files for whitespace, line endings, and non-ASCII characters doesn't handle submodule additions very well. We have a hardcoded list of directories to skip when validating:
STL/tools/validate/validate.cpp
Lines 155 to 162 in 098333c
| static constexpr array skipped_directories{ | |
| ".git"sv, | |
| ".vs"sv, | |
| ".vscode"sv, | |
| "llvm-project"sv, | |
| "out"sv, | |
| "vcpkg"sv, | |
| }; |
Here's the problem scenario:
- A PR adds a
catsubmodule, and updatesvalidate.cppto skip that directory. - The VMs properly init that submodule, and skip it while validating.
- At this point, the
catPR hasn't been merged yet! - A totally separate PR (modifying
mousemachinery or whatever) triggers checks on those VMs. - The VMs don't clean out the
catdirectory, and themousePR doesn't containvalidate.cppchanges to skipcat, so all of thecatfiles are scanned and fail to validate.
I suspect that this is involved:
STL/azure-devops/run_build.yml
Lines 13 to 14 in 098333c
| - checkout: self | |
| submodules: recursive |
According to the YAML schema, do we need to set clean: true so we don't have to worry about lingering submodules?
Metadata
Metadata
Assignees
Labels
fixedSomething works now, yay!Something works now, yay!infrastructureRelated to repository automationRelated to repository automation