Skip to content

Conversation

@StephanTLavavej
Copy link
Member

@StephanTLavavej StephanTLavavej commented Jun 29, 2022

This should fix #396 - see my analysis there.

I initially wanted to annihilate the entire workspace with workspace: clean: all. While I believe that would be effective and simpler to reason about (making reused machines perform completely fresh clones), it would be slower when machines are reused. Even though the actual time savings are rather small (~15 seconds), the total machine time across many VMs is more significant.

This uses git clean --quiet -x -d -f -f with two force options because we want to clean up any leftover submodules; git will refuse to do that if there's only one force option. (--quiet suppresses potentially voluminous log output which we aren't interested in.)

This also makes a vaguely related change to the submodule checkout scripts. They now use two force options for consistency (even though we aren't worried about nested submodules), and this changes boost-math to follow llvm-project's commands more closely. It replaces git checkout -f FETCH_HEAD with git reset --quiet --hard FETCH_HEAD; they have the same effect, but the latter avoids emitting the "detached HEAD" warning. It also adds a clean command.

@StephanTLavavej StephanTLavavej added the infrastructure Related to repository automation label Jun 29, 2022
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner June 29, 2022 02:23
@StephanTLavavej
Copy link
Member Author

@CaseyCarter I added the double-force options and updated the PR description.

@StephanTLavavej StephanTLavavej mentioned this pull request Jun 30, 2022
4 tasks
@StephanTLavavej StephanTLavavej self-assigned this Jun 30, 2022
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit c45fe47 into microsoft:main Jul 1, 2022
@StephanTLavavej StephanTLavavej deleted the decontamination branch July 1, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Related to repository automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub: File validation interacts badly with PRs adding submodules

2 participants