[benchmark] add gbenchmark #2780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barcharcraz
suggested changes
Jun 11, 2022
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
barcharcraz
suggested changes
Jun 14, 2022
CaseyCarter
reviewed
Jun 15, 2022
CaseyCarter
reviewed
Jun 15, 2022
This comment was marked as resolved.
This comment was marked as resolved.
miscco
reviewed
Jun 16, 2022
strega-nil-ms
force-pushed
the
benchmarkin
branch
from
db533b2 to
3e830fe
Compare
CaseyCarter
approved these changes
Jun 20, 2022
StephanTLavavej
requested changes
Jun 21, 2022
This comment was marked as resolved.
This comment was marked as resolved.
CaseyCarter
reviewed
Jun 23, 2022
CaseyCarter
reviewed
Jun 23, 2022
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
CaseyCarter
approved these changes
Jun 29, 2022
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Thanks! Just a few minor issues, I will double-check and push changes.
StephanTLavavej
approved these changes
Jun 30, 2022
Member
|
@strega-nil-ms @CaseyCarter I pushed a small set of changes - if anything looks wrong, please meow! Otherwise I believe this is ready. Thanks for this major step forward! 😸 |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for implementing this long-awaited infrastructure, and congratulations for this major PR! 🏎️ 🚀 😻 |
Closed
fsb4000
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
Co-authored-by: Nicole Mazzuca <mazzucan@outlook.com> Co-authored-by: Stephan T. Lavavej <stl@nuwen.net> Co-authored-by: Casey Carter <cartec69@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the google benchmark library, along with one benchmark from @BillyONeal's test benchmarking branch.
One "enjoyable" thing about having a benchmarking library with pre-built binaries is that we have to make sure there isn't any conflict with the STL; this means that we need to make sure that the library links with our STL.
Given that we build multiple configurations in one build, which is Not Normal CMake, this means that we need to choose one configuration for the benchmarking library to link to - we do this with cache variables. We default to dynamic release mode.
To Do