chore: update tslib#2899
Merged
jakebailey merged 6 commits intomicrosoft:v2from Jul 24, 2023
Zamiell:tslib
Merged
Conversation
Member
|
Pulled out the other ones into #2900; this is an ongoing problem, unfortunately. |
Contributor
Author
|
do you wanna rebase this on main for me? not sure what to do specifically |
jakebailey
reviewed
Jul 21, 2023
| | "reference/Decorators.md" | ||
| | "reference/ESM Support for Node.md" | ||
| | "reference/Enums.md" | ||
| | "reference/ESM Support for Node.md" |
Member
There was a problem hiding this comment.
I honestly have no idea why these files are still changed after I merged #2900. Probably best to drop them from the PR and limit this to the package.json and lockfile updates, although my impression is that even if we fix this one thing, you get an even more cryptic issue later in non-node-16 anyway so...
Member
There's no need for that; Github figures it out! other than the... other changes? No idea. |
Contributor
Author
|
ok i did some manual edits and it should be good now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR updates the tslib dep to latest in the package.json file and yarn.lock, which fixes
yarn bootstrapfailing on node 18.the other changes are simply a result of performing the
yarn bootstrapcommand, so I can take them out of the PR if you want.