Skip to content

Update files modified by bootstrap#2900

Merged
jakebailey merged 1 commit intomicrosoft:v2from
jakebailey:fix-boostrap-2
Jul 21, 2023
Merged

Update files modified by bootstrap#2900
jakebailey merged 1 commit intomicrosoft:v2from
jakebailey:fix-boostrap-2

Conversation

@jakebailey
Copy link
Member

These files are modified in bootstrap because some of their source files changed. We have no mechanism to detect this at the moment so here's a fixup.

@jakebailey jakebailey mentioned this pull request Jul 21, 2023
@jakebailey jakebailey enabled auto-merge (squash) July 21, 2023 20:38
@jakebailey jakebailey merged commit ac69be3 into microsoft:v2 Jul 21, 2023
@orta
Copy link
Contributor

orta commented Jul 21, 2023

A lot of these were intentionally made to be marked as changed in git (so that it was easy to know all of the changes on an TypeScript version update) but I'm pretty sure they can be safely gitignored if that's more annoying than useful

@jakebailey jakebailey deleted the fix-boostrap-2 branch July 21, 2023 21:12
@jakebailey
Copy link
Member Author

I don't mind them being committed per se, but the problem is that the CI doesn't actually error when bootstrap changes files and they aren't committed. That and I've frequently had issues with bootstrap in general not making changes unless I fully git clean'd and re-bootstrapped, so if that happens, it's a little frustrating for PR senders to fix up. I don't have a great solution here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants