createScanner function no longer exposed in typescriptServices.d.ts on latest build

[gscshoyru]

createScanner was previously exposed in #3020, along with the Scanner class. However, in the latest master branch of typescript, the Scanner class is still there but createScanner is missing.

[danquirk]

@mhegazy intentional or bug?

[mhegazy]

that was not intentional.

[mhegazy]

feel free to send a PR removing the /* @internal */ comment and that will make it show up again.

[adidahiya]

I'll take up this PR.

[adidahiya]

wait, nevermind, this is no longer an issue on master, despite the /* @internal */ above createScanner. maybe that's because of the comment in between the internal flag and the function name? https://github.com/Microsoft/TypeScript/blob/master/src/compiler/scanner.ts#L677

looks like /* @internal */ should be removed there anyway though.

we also use computeLineStarts() in tslint and would like that exported in typescriptServices.d.ts. would you be cool with making that non-internal? https://github.com/Microsoft/TypeScript/blob/master/src/compiler/scanner.ts#L279

[DanielRosenwasser]

@adidahiya if you can send a quick PR that would be great, it should indeed be removed

[DanielRosenwasser]

Oh, regarding computeLineStarts, @mhegazy should answer that

[mhegazy]

what do you uses that for? would not getPositionOfLineAndCharacter and getLineAndCharacterOfPosition be sufficient? lineStarts is really an implementation detail.