Skip to content

Conversation

@mhegazy
Copy link
Contributor

@mhegazy mhegazy commented May 4, 2015

No description provided.

@vladima
Copy link
Contributor

vladima commented May 4, 2015

👍

mhegazy added a commit that referenced this pull request May 4, 2015
@mhegazy mhegazy merged commit 80cff5b into master May 4, 2015
@mhegazy mhegazy deleted the exposeScanner branch May 4, 2015 17:00
@CyrusNajmabadi
Copy link
Contributor

I would not expose the scanner. It is an implementation detail. We should be exposing this through our AST API.

-- Cyrus

From: Mohamed Hegazymailto:notifications@github.com
Sent: ‎5/‎4/‎2015 9:52 AM
To: Microsoft/TypeScriptmailto:TypeScript@noreply.github.com
Subject: [TypeScript] Fix #3012: expose scanner (#3020)

mhegazy wants to merge 1 commit into master from exposeScanner:


You can view, comment on, or merge this pull request online at:

#3020

Commit Summary

File Changes

Patch Links:


Reply to this email directly or view it on GitHubhttps://github.com//pull/3020.

@ashwinr
Copy link

ashwinr commented May 6, 2015

#3012 is for users like TSLint that need to walk through all nodes of a specific kind (like comment, whitespace etc.). I'm cool with exposing it somewhere, we've been using the scanner to do this work currently.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants