Move code out of closure in getDocumentHighlights
#13548
Merged
+500
−506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
document_highlights_unclosure
branch
from
444b099 to
cca712f
Compare
…f `getSemanticDocumentHighlights` and `getSyntacticDocumentHighlights`. Also return a `Node[]` instead of a `HighlightSpan[]` where possible and do mapping from Node to HighlightSpan in one place.
ghost
force-pushed
the
document_highlights_unclosure
branch
from
cca712f to
bddcbc5
Compare
sandersn
approved these changes
Jan 17, 2017
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...then again out of
getSemanticDocumentHighlightsandgetSyntacticDocumentHighlights.Also return a
Node[]instead of aHighlightSpan[]where possible and do mapping from Node to HighlightSpan in one place.Continuation of #13476 and #13534.