Fix 'arguments' check in class field initializer or static initialization block #44393
Conversation
|
|
src/compiler/checker.ts
Outdated
|
|
||
| const firstFunctionLikeContainerOrClassLikeContainer = findAncestor(node.parent, node => isClassLike(node) || isFunctionLike(node))!; | ||
| if (firstFunctionLikeContainerOrClassLikeContainer.kind === SyntaxKind.ClassExpression || firstFunctionLikeContainerOrClassLikeContainer.kind === SyntaxKind.ClassDeclaration) { | ||
| error(node, Diagnostics.arguments_is_not_allowed_in_class_field_initializer_or_static_initialization_block); |
There was a problem hiding this comment.
And it should not execute the following two lines.
You should add
return errorType;
DanielRosenwasser
left a comment
DanielRosenwasser
left a comment
There was a problem hiding this comment.
Technically there's an isInPropertyInitializer but the suggestions I've given seem cheaper.
src/compiler/diagnosticMessages.json
Outdated
| "category": "Error", | ||
| "code": 2812 | ||
| }, | ||
| "'arguments' is not allowed in class field initializer or static initialization block.": { |
There was a problem hiding this comment.
There's no static initialization block, right?
| "'arguments' is not allowed in class field initializer or static initialization block.": { | |
| "'arguments' cannot be referenced in property initializers.": { |
There was a problem hiding this comment.
Oh, the error message is copied from Chrome. But Chrome does not support static initialization block either, that's strange.
src/compiler/checker.ts
Outdated
| } | ||
| } | ||
|
|
||
| const firstFunctionLikeContainerOrClassLikeContainer = findAncestor(node.parent, node => isClassLike(node) || isFunctionLike(node))!; |
There was a problem hiding this comment.
Consider moving this higher and reusing it for container
const firstFunctionLikeContainerOrClassLikeContainer = findAncestor(node.parent, node => isClassLike(node) || isFunctionLike(node))!;
const container = isClassLike(firstFunctionLikeContainerOrClassLikeContainer) ?
findAncestor(firstFunctionLikeContainerOrClassLikeContainer.parent, isFunctionLike)! :
firstFunctionLikeContainerOrClassLikeContainer;fix Diagnostics message
|
@DanielRosenwasser |
|
only node14 failed，werid |
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Looks good to me -- what do you think @DanielRosenwasser ?
@exoticknight you can merge now from main to get diagnosticMessages up to date, or you can wait until @DanielRosenwasser signs off, it's up to you.
# Conflicts: # src/compiler/diagnosticMessages.json
|
I looked over the comment history and I think this is ready to go once CI finishes one more time. |
5 participants
Fixes #44269