Skip to content

Fix 'arguments' check in class field initializer or static initialization block #44393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandersn merged 11 commits into from
Jun 21, 2021
Merged

Fix 'arguments' check in class field initializer or static initialization block #44393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a4aff9f
Fix 'arguments' check in class field initializer or static initializa…
exoticknight Jun 2, 2021
91b2202
Merge branch 'microsoft:main' into master
exoticknight Jun 3, 2021
abed90c
return errorType
exoticknight Jun 3, 2021
e98c4b7
Merge branch 'master' of https://github.com/exoticknight/TypeScript
exoticknight Jun 3, 2021
68a1212
Merge branch 'main' of https://github.com/microsoft/TypeScript
exoticknight Jun 4, 2021
0d93e96
use isInPropertyInitializer
exoticknight Jun 4, 2021
e1ea94f
Merge remote-tracking branch 'upstream/main'
exoticknight Jun 6, 2021
f413f7a
Merge branch 'main'
exoticknight Jun 9, 2021
463d5a9
Merge branch 'main' of https://github.com/microsoft/TypeScript
exoticknight Jun 15, 2021
50902e7
Merge branch 'main'
exoticknight Jun 19, 2021
f9f3173
Merge branch 'main'
exoticknight Jun 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24227,6 +24227,11 @@ namespace ts {
// To avoid that we will give an error to users if they use arguments objects in arrow function so that they
// can explicitly bound arguments objects
Copy link
Contributor

@Jack-Works Jack-Works Jun 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it should not execute the following two lines.

You should add

return errorType;

Copy link
Contributor Author

@exoticknight exoticknight Jun 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

if (symbol === argumentsSymbol) {
if (isInPropertyInitializer(node)) {
error(node, Diagnostics.arguments_cannot_be_referenced_in_property_initializers);
return errorType;
}

const container = getContainingFunction(node)!;
if (languageVersion < ScriptTarget.ES2015) {
if (container.kind === SyntaxKind.ArrowFunction) {
Expand Down
Loading