Skip to content

Conversation

@ddzz
Copy link
Contributor

@ddzz ddzz commented Apr 24, 2022

This PR adds Node v18 to the CI configuration and removes Node v17. actions/setup-node has also been updated to the latest version.

Fixes #48825

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Apr 24, 2022
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@ghost
Copy link

ghost commented Apr 24, 2022

CLA assistant check
All CLA requirements met.

@andrewbranch
Copy link
Member

IIRC we may have agreed that we want to test latest plus the last two LTS releases before that, so we would be replacing 17 here, not adding to it.

@weswigham
Copy link
Member

Yep 18 should just replace 17 as current active development version.

@ddzz
Copy link
Contributor Author

ddzz commented Apr 26, 2022

PR has been updated. The Azure pipeline needs to be updated -- it appears that this lives in a different repo?

@andrewbranch andrewbranch merged commit bab02d2 into microsoft:main Apr 27, 2022
@andrewbranch
Copy link
Member

I’ve updated the Azure Pipeline. Thanks @ddzz!

@ddzz ddzz deleted the node-18 branch April 27, 2022 15:53
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test under Node v18 in CI

4 participants