Use symbolic GitHub Actions Node.js versions #49403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Member
|
Thanks! |
jablko
added a commit
to jablko/TypeScript
that referenced
this pull request
Jun 7, 2022
This reverts commit 0d7fbbb.
jablko
added a commit
to jablko/TypeScript
that referenced
this pull request
Jun 7, 2022
jablko
added a commit
to jablko/TypeScript
that referenced
this pull request
Jun 7, 2022
sandersn
added a commit
that referenced
this pull request
Jun 7, 2022
… sharedmemory file (#49204) * feat(sharedmemory): Added file waitAsync function * fix: Adjusted promise return type * Fix(sharedmemory): Addressed PR comments * Fix: Removed unused @see at sharedmemory * Feat: Added tests to shared memory * Fix: fixed ordering in libs.json * Feat: Added shared memory to line parser * Update tests es2022SharedMemory.ts as sugested Co-authored-by: Eyal Halpern Shalev <eyalsh@gmail.com> * Update es2022SharedMemory.ts * feat: Accepted baselines * fix: Adjusted grammar changes in jsdoc * fix(47821): skip nodes with export modifiers (#47829) * Use symbolic GitHub Actions Node.js versions (#49403) * update baselines Co-authored-by: Eyal Halpern Shalev <eyalsh@gmail.com> Co-authored-by: Oleksandr T <oleksandr.tarasiuk@outlook.com> Co-authored-by: Jack Bates <jack@nottheoilrig.com> Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
jablko
added a commit
to jablko/TypeScript
that referenced
this pull request
Jun 7, 2022
RyanCavanaugh
pushed a commit
that referenced
this pull request
Jun 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did was, in the CI workflow, replace Node.js v18 with "*", v16 ->
lts/*and v14 ->lts/-1. This will continue to test on the latest version of Node.js plus the last two LTS versions, but without updating the workflow when Node.js is released."*" will be v18 until October, when v19 is scheduled to be released, then v20 next April.
lts/*andlts/-1will be v16 and v14 until v18 enters LTS (also in October).In the other workflows where we use a single version of Node.js I dropped the
node-versionactions/setup-node input, which will use the version that comes with the runner (currently v16).While I was editing the actions/setup-node inputs I also dropped
registry-url: https://registry.npmjs.org/because:registry-urlinput sets up authentication, however the only workflow that runsnpm publishis the nightly workflow, and we can do the same thing without actions/setup-node, using theNPM_TOKENenvironment variable.I also dropped the
CI: trueenvironment variable because it's always set by GitHub Actions./cc @andrewbranch and @weswigham