Skip to content

Fixed "add missing properties" codefix for positions with nullable contextual types #60328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jakebailey merged 3 commits into from
Oct 23, 2024
Merged

Fixed "add missing properties" codefix for positions with nullable contextual types #60328

jakebailey merged 3 commits into from
Oct 23, 2024

Conversation

@Andarist
Copy link
Contributor

@Andarist Andarist commented Oct 23, 2024

fixes #60327

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Oct 23, 2024
jakebailey
jakebailey approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is correct.

@jakebailey jakebailey merged commit 6a90111 into microsoft:main Oct 23, 2024
@Andarist Andarist deleted the fix/fix-missing-members-nullable-types branch October 23, 2024 18:59
@sandersn sandersn removed this from PR Backlog Apr 22, 2025
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

@jakebailey jakebailey jakebailey approved these changes

Assignees

No one assigned

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add missing properties for optional parameters and optional properties

4 participants

@Andarist @andrewbranch @jakebailey @typescript-bot