Skip to content

Add source link to MRTCore#1066

Merged
huichen123 merged 2 commits intomainfrom
user/huichen/mrtsourcelink
Jul 15, 2021
Merged

Add source link to MRTCore#1066
huichen123 merged 2 commits intomainfrom
user/huichen/mrtsourcelink

Conversation

@huichen123
Copy link
Copy Markdown
Contributor

No description provided.

@ghost ghost added the needs-triage label Jul 15, 2021
@huichen123
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@rohanp-msft
Copy link
Copy Markdown
Contributor

Do we need to update any of the tasks in the YML file?

@huichen123
Copy link
Copy Markdown
Contributor Author

Do we need to update any of the tasks in the YML file?

don't think so. the source link is embedded in the pdb files.

@huichen123 huichen123 merged commit a80dae1 into main Jul 15, 2021
@huichen123 huichen123 deleted the user/huichen/mrtsourcelink branch July 15, 2021 19:29
@jefgen
Copy link
Copy Markdown
Member

jefgen commented Jul 15, 2021

Just curious, this also works for native code? The docs seem to only mention .NET code.

EDIT: Also, do we need to add /p:SourceLinkCreate=true ?

@huichen123
Copy link
Copy Markdown
Contributor Author

Just curious, this also works for native code? The docs seem to only mention .NET code.

EDIT: Also, do we need to add /p:SourceLinkCreate=true ?

doc has a section for "Using Source Link in C++ projects". Not sure about the command line parameter. I see the source link in the pdb files. Unfortunately current binary is not compatible due to namespace change, I cannot try by replacing binaries and debugging.

@jefgen
Copy link
Copy Markdown
Member

jefgen commented Jul 15, 2021

Thanks Hui.

FWIW, the docs here seem to imply that all you need to do is add the packages (which is what this PR does).

Looking at the build log, I do see various /sourcelink being added. For example:
/sourcelink:"x64\Release\Microsoft.Windows.ApplicationModel.Resources.sourcelink.json"

So maybe this is all that is needed. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants