Add source link to product code#1500
Merged
DefaultRyan merged 1 commit intomainfrom Sep 29, 2021
Merged
Conversation
huichen123
reviewed
Sep 28, 2021
| @@ -0,0 +1,6 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <packages> | |||
| <package id="Microsoft.Build.Tasks.Git" version="1.1.0-beta-20204-02" targetFramework="native" developmentDependency="true" /> | |||
Contributor
Member
There was a problem hiding this comment.
Definitely something to look at in the future - also common .props file that projects reference so we don't have so many edits.
Member
There was a problem hiding this comment.
Nice idea but alas, packages.config has no #include/import/etc mechanism :-(
jonwis
approved these changes
Sep 28, 2021
| @@ -1,4 +1,7 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
Member
There was a problem hiding this comment.
Is there a way to at least centralize these packages.config files across the solution?
Member
There was a problem hiding this comment.
Yes but not easily (VS doesn't provide a mechanism but we can, with work). It's come up in ES discussions. Ideas so far include...
- build\packages.props as a single shared master list of WIL, C++/WinRT, etc definitions/versions instead of in each *proj file
- new tooling (UpdatePackagesConfig.ps1 etc) to crawl the directory tree rewriting packages.config content per packages.props
- pipeline checks all packages.config match (and match versions in packages.props)
- Non-nuget packaging tech (eg VCPKG)
This overlaps the project-management topic we've discussed but haven't tackled yet. But that day's getting closer... :-)
DrusTheAxe
approved these changes
Sep 28, 2021
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding source link allows us to see and download source code when debugging (by inserting some metadata into the debugger about how to retrieve the file from source control). This is taking the same approach as #1066 and applying it to the rest of the product code in the repo.
Verified by:
With this change, I now see the following:
Notice
winmain.cpp @ 58. In my windbg, this is a hyperlink that I can click, or I can manually open:And I get the source code in my debugger: