Fixes for fqdn and github_host#33
Merged
danielmeppiel merged 3 commits intomicrosoft:mainfrom Dec 1, 2025
Merged
Conversation
- Fix critical typo: .strip → .strip() in version validation (line 666)
* Would cause crash when YAML parses version as numeric type (e.g., 1.0 instead of '1.0')
* Now safely handles both string and numeric version values
- Add TestEnterpriseHostHandling class with 3 new tests:
* test_clone_fallback_respects_enterprise_host: Ensures Method 3 fallback uses
configured host (from GITHUB_HOST or explicit FQDN), not hardcoded github.com
* test_host_persists_through_clone_attempts: Verifies host attribute persists
correctly across all _build_repo_url() calls
* test_multiple_hosts_resolution: Validates mixing dependencies from multiple
GitHub hosts (github.com + enterprise instances)
- Add test_string_representation_with_enterprise_host:
* Verifies __str__() includes host prefix for enterprise dependencies
* Tests the PR microsoft#33 change to DependencyReference.__str__() method
- Add test_validate_numeric_version_types:
* Ensures version validation handles YAML numeric types without crashing
* Tests defensive str() cast added in PR microsoft#33
- Update existing tests to handle explicit host in string representations:
* test_string_representation: Now validates components instead of exact match
* test_virtual_package_str_representation: Checks for presence of key parts
All 599 unit tests pass. Host resolution verified for all scenarios:
✅ Bare 'owner/repo' → defaults to github.com
✅ Bare 'owner/repo' with GITHUB_HOST → respects GITHUB_HOST env var
✅ Explicit FQDN → always overrides GITHUB_HOST (e.g., 'partner.ghe.com/owner/repo')
danielmeppiel
added a commit
that referenced
this pull request
Apr 30, 2026
…#1073) * docs(notice): rename NOTICE.md -> NOTICE; add CLA third-party section Two changes, one file rename: 1. Rename NOTICE.md -> NOTICE, matching the Apache / CNCF convention used by upstream third-party-attribution files (kubernetes-sigs/kro, kubernetes-sigs/headlamp, etc.). The .md extension was non-idiomatic for a generated legal artifact -- NOTICE files are read by tooling (license scanners, SBOM generators) that match on the bare filename. Generator (scripts/generate-notice.py), Makefile target, and the NOTICE Drift Check workflow are all updated to operate on the extension-less path. 2. Add a 'Submitted on behalf of a third-party' section to NOTICE, crediting five contributors whose pull requests landed before the microsoft-github-policy-service CLA bot recorded a signature on file. The repo transferred from danielmeppiel/awd-cli to the microsoft org; some early PRs predate CLA enforcement, and we could not retroactively reach all contributors. Mirrors section 7 of common CLA texts (the wording adopted by CNCF NOTICE files). Driven by a new _third_party_submissions block in scripts/notice-metadata.yaml -- legally-significant wording stays alongside the per-component data, not buried in code. Contributors named (verified via Check Runs API against the microsoft-github-policy-service app, license/cla check on every merged PR by each suspected author): - @pofallon (PR #4) - @richgo (PRs #8, #25, #26, #33, #34) - @ryanfk (PR #92 -- bot ran with conclusion=null, output: 'Contributor License Agreement is not agreed yet.') - @foutoucour (PR #108) - @Jah-yee (PR #184) Listed contributors who later sign the CLA (or who were signed under a different GitHub account at the time) can request removal via issue. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs(notice): trim third-party section preamble Strip the historical/CNCF-citation paragraph and the verbatim CLA-section-7 quote. Keep only the active sentence (what the listing means + how to request removal). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs(notice): address PR #1073 review Three fixes from copilot-pull-request-reviewer: 1. Drop spurious leading '---' separator in the third-party-submissions renderer. render_component already ends each component with '---\n\n', so prepending another '---' produced two consecutive separators in NOTICE. Verified: separator count dropped from 17 to 16. 2. Sweep stale 'NOTICE.md' references in scripts/generate-notice.py (top-level docstring, Modes section, ComponentMeta and DepSpec field docstrings). The constant was renamed; the docs lagged. 3. Append (#1073) PR refs to both CHANGELOG entries; ASCII-correct the arrow ('->' instead of '->'). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <copilot-rework@github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
⚡ Quick Start - Use Specialized Templates
For better guidance, consider using our specialized templates:
Description
github.com was still being pulled through post validation once the package download process started. Also fixed an exception where a non-compliant semver is used for a package.
Type of Change
🏷️ IMPORTANT: Apply the appropriate label after creating this PR:
enhancementorfeaturebugorfixdocumentationordocsignore-for-releaseTesting
Checklist
Fixes # (issue)