Skip to content

fix: support spaces in Azure DevOps project names#92

Merged
danielmeppiel merged 3 commits intomicrosoft:mainfrom
ryanfk:fix/ado-project-names-with-spaces
Feb 24, 2026
Merged

fix: support spaces in Azure DevOps project names#92
danielmeppiel merged 3 commits intomicrosoft:mainfrom
ryanfk:fix/ado-project-names-with-spaces

Conversation

@ryanfk
Copy link

@ryanfk ryanfk commented Feb 19, 2026

Summary

  • Azure DevOps project names can contain spaces (e.g., America Oh Yeah), but apm install rejected them with "not accessible or doesn't exist"
  • The character-validation regexes in DependencyReference.parse() only allowed [a-zA-Z0-9._-], blocking spaces and %20-encoded input
  • URL builder functions (build_ado_https_clone_url, build_ado_ssh_url, build_ado_api_url) interpolated project names directly without percent-encoding

Changes

src/apm_cli/models/apm_package.py:

  • Decode percent-encoded input (%20 → space) early in parse()
  • Allow spaces in ADO path-component validation regexes
  • Decode percent-encoded path components after URL parsing
  • URL-encode project segment in to_github_url()

src/apm_cli/utils/github_host.py:

  • URL-encode the project parameter in build_ado_https_clone_url(), build_ado_ssh_url(), and build_ado_api_url()

All three input forms now work

apm install dev.azure.com/org/My%20Project/repo
apm install "dev.azure.com/org/My Project/repo"
apm install dev.azure.com/org/My%20Project/_git/repo

Test plan

  • All 99 existing tests pass — confirms no regressions for project names without spaces
  • Verified parsing with %20, literal spaces, and _git segment
  • Verified URL builders produce correctly encoded URLs

Fixes #89

🤖 Generated with Claude Code

Ryan Fiust-Klink and others added 2 commits February 19, 2026 17:04
ADO project names may contain spaces (e.g., "Americas Praxair tfs").
Previously, `apm install` rejected these with "not accessible or
doesn't exist" because the character-validation regexes only allowed
`[a-zA-Z0-9._-]`.

Changes:
- Decode percent-encoded input (`%20`) early in DependencyReference.parse()
- Allow spaces in ADO path-component validation regexes
- URL-encode the project segment when building HTTPS clone, SSH, and
  REST API URLs via build_ado_* helpers and to_github_url()

All three input forms now work:
  apm install dev.azure.com/org/My%20Project/repo
  apm install dev.azure.com/org/My Project/repo
  apm install dev.azure.com/org/My%20Project/_git/repo

Fixes microsoft#89

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Test parsing with %20-encoded and literal spaces in project names
- Test to_github_url() produces properly encoded ADO URLs
- Test that spaces are still rejected in GitHub owner/repo names
- Test build_ado_https_clone_url, build_ado_ssh_url, build_ado_api_url with spaces
@danielmeppiel
Copy link
Collaborator

@ryanfk thank you for spotting this and submitting the PR!

I added unit tests covering the missing cases:

  • Parsing: %20-encoded spaces, literal spaces, multi-word project names
  • to_github_url(): verifies properly percent-encoded output
  • Negative case: spaces still rejected in GitHub owner/repo names
  • URL builders: build_ado_https_clone_url, build_ado_ssh_url, build_ado_api_url all properly encode spaces

@danielmeppiel danielmeppiel added the bug Something isn't working label Feb 23, 2026
@danielmeppiel danielmeppiel added this to the 0.7.4 milestone Feb 23, 2026
@SebastienDegodez
Copy link
Collaborator

LGTM

@danielmeppiel danielmeppiel merged commit 0d957eb into microsoft:main Feb 24, 2026
7 checks passed
@JustinGOSSES
Copy link

@microsoft-github-policy-service rerun

@microsoft-github-policy-service

@ryanfk please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] apm install fails for Azure DevOps projects with spaces in the project name

4 participants