Skip to content

Semantic Memory Migration Breakout#308

Merged
crickman merged 39 commits intofeature-semantic-memoryfrom
feature-semantic-memory-migration
Sep 20, 2023
Merged

Semantic Memory Migration Breakout#308
crickman merged 39 commits intofeature-semantic-memoryfrom
feature-semantic-memory-migration

Conversation

@crickman
Copy link
Copy Markdown
Contributor

@crickman crickman commented Sep 6, 2023 •
edited
Loading

Motivation and Context

Break-out memory migration work for ease of review

Description

One-time migration of all chat memory (working and long-term).
Removes all memory sources from storage

image

Needs to be able to create two (x2) indexes.

To reset migration, just remove chatmemory and global-documents

Pushed targeted fixes in #365

Contribution Checklist

@github-actions github-actions Bot added webapp Pull requests that update Typescript code webapi Pull requests that update .net code PR: ready for review labels Sep 6, 2023
@crickman crickman self-assigned this Sep 6, 2023
teresaqhoang
teresaqhoang reviewed Sep 8, 2023
View reviewed changes
Comment thread webapi/Controllers/ChatMigrationController.cs Outdated
Comment thread webapi/Services/ChatMemoryMigrationService.cs Outdated
Comment thread webapp/src/App.tsx Outdated
Comment thread webapp/src/components/views/BackendProbe.tsx Outdated
@github-actions github-actions Bot removed the webapp Pull requests that update Typescript code label Sep 12, 2023
@crickman crickman added PR: in progress memory Issues or questions related to memory and removed PR: ready for review labels Sep 12, 2023
@crickman crickman changed the title Migration POC Semantic Memory Migration POC Sep 12, 2023
@crickman crickman changed the title Semantic Memory Migration POC Semantic Memory Migration Integration Sep 18, 2023
@github-actions github-actions Bot added the webapp Pull requests that update Typescript code label Sep 19, 2023
@crickman crickman marked this pull request as ready for review September 19, 2023 02:42
@github-actions github-actions Bot removed the webapp Pull requests that update Typescript code label Sep 19, 2023
@crickman crickman changed the title Semantic Memory Migration Integration Semantic Memory Migration Breakout Sep 19, 2023
alliscode
alliscode reviewed Sep 19, 2023
View reviewed changes
Comment thread webapi/Controllers/MaintenanceController.cs Outdated
Comment thread webapi/Services/MemoryMigration/ChatMemoryMigrationService.cs
Comment thread webapi/Services/MemoryMigration/ChatMigrationMaintenanceAction.cs Outdated
TaoChenOSU
TaoChenOSU reviewed Sep 19, 2023
View reviewed changes
Comment thread webapi/Services/MemoryMigration/ChatMemoryMigrationService.cs
Comment thread webapi/Services/MemoryMigration/ChatMigrationStatus.cs
@crickman crickman requested a review from TaoChenOSU September 19, 2023 22:02
@crickman crickman merged commit 9024822 into feature-semantic-memory Sep 20, 2023
@crickman crickman deleted the feature-semantic-memory-migration branch September 20, 2023 00:42
jdtoombs pushed a commit to jdtoombs/chat-copilot that referenced this pull request Apr 10, 2025
@GrahamS-Quartech
[AB#97] Hyperlinks in chat bubble citations (microsoft#308)
3d94687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alliscode alliscode alliscode approved these changes

@teresaqhoang teresaqhoang Awaiting requested review from teresaqhoang

+1 more reviewer

@TaoChenOSU TaoChenOSU TaoChenOSU approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@crickman crickman

Labels

memory Issues or questions related to memory webapi Pull requests that update .net code

Projects

No open projects
Apps & Services Semantic Kernel
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crickman @TaoChenOSU @alliscode @teresaqhoang