Conversation
crickman
added
bug
crickman
requested review from
TaoChenOSU,
alliscode,
gitri-ms and
teresaqhoang
4 tasks
dehoward
reviewed
Sep 19, 2023
alliscode
previously approved these changes
Sep 19, 2023
Co-authored-by: Teresa Hoang <125500434+teresaqhoang@users.noreply.github.com>
…ft/chat-copilot into fix-memory-n-maintenance
teresaqhoang
approved these changes
Sep 19, 2023
crickman
added a commit
that referenced
this pull request
Sep 20, 2023
### Motivation and Context Break-out memory migration work for ease of review ### Description One-time migration of all chat memory (working and long-term). Removes all memory sources from storage  Needs to be able to create two (x2) indexes. To reset migration, just remove `chatmemory` and `global-documents` Pushed targeted fixes in #365 ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
teamleader-dev
pushed a commit
to vlink-group/chat-copilot
that referenced
this pull request
Oct 7, 2024
### Motivation and Context <!-- Thank you for your contribution to the chat-copilot repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Testing [the semantic-memory integration PR](microsoft#152), discovered a couple issues: 1. Stabilize maintenance state changes and controller result 2. Addressed root-cause for connecter issue reported in: microsoft#351 and microsoft#215 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> - Decouple exception handling for `SearchAsync` and `SaveInformationAsync` - Change from "ref" to "state" handling for BackendProbe - Refine handling of maintenance response ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Teresa Hoang <125500434+teresaqhoang@users.noreply.github.com>
kb0039
pushed a commit
to aaronba/chat-copilot
that referenced
this pull request
Jan 8, 2025
### Motivation and Context <!-- Thank you for your contribution to the chat-copilot repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Testing [the semantic-memory integration PR](microsoft#152), discovered a couple issues: 1. Stabilize maintenance state changes and controller result 2. Addressed root-cause for connecter issue reported in: microsoft#351 and microsoft#215 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> - Decouple exception handling for `SearchAsync` and `SaveInformationAsync` - Change from "ref" to "state" handling for BackendProbe - Refine handling of maintenance response ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Teresa Hoang <125500434+teresaqhoang@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Testing the semantic-memory integration PR, discovered a couple issues:
Description
SearchAsyncandSaveInformationAsyncContribution Checklist