Semantic Memory Integration into Copilot Chat#152
Merged
Conversation
### Motivation and Context <!-- Thank you for your contribution to the copilot-chat repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [Contribution Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
### Motivation and Context <!-- Thank you for your contribution to the copilot-chat repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> 1. Rename project from SemanticMemoryPipelineService to CopilotChatMemoryPipeline. 2. SemanticMemory.Service to CopilotChat.MemoryPipeline. 3. Remove nuget.config. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [Contribution Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
…t/chat-copilot into feature-semantic-memory
github-actions
Bot
added
webapp
crickman
added
enhancement
crickman
temporarily deployed
to
feature-semantic-memory
GitHub Actions
Inactive
github-actions
Bot
added
PR: ready for review
github actions
crickman
added
preview
crickman
temporarily deployed
to
feature-semantic-memory
GitHub Actions
Inactive
Contributor
|
Hi, One question regarding this PR. By moving to semantic-memory, you remove the possibility to add new connectors directly to chat-copilot right? We would only be able to use already implemented connectors in semantic-memory, if we want to leverage on other database, third-party connectors might be difficult to add in that case... |
Contributor
Author
This is correct. In fact, due to a lack in parity we are temporarilly regressing support for Postgres and Chroma connectors. I expect the memory-service to quickly match parity with what is currently supported in sk. As the memory-service evolves to support more complex scenarios, then the value proposition may be quite a bit higher than the connector model. But, yes, utimately chat-copilot will no longer make use of the |
### Motivation and Context Break-out memory migration work for ease of review ### Description One-time migration of all chat memory (working and long-term). Removes all memory sources from storage  Needs to be able to create two (x2) indexes. To reset migration, just remove `chatmemory` and `global-documents` Pushed targeted fixes in #365 ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
alliscode
previously approved these changes
Sep 20, 2023
…t/chat-copilot into feature-semantic-memory
alliscode
approved these changes
Sep 21, 2023
This was referenced Sep 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Motivation and Context
Integration of chat-copilot with https://github.com/microsoft/semantic-memory. With this change, chat-copilot no longer utilizes the https://github.com/microsoft/semantic-kernel connector
Description
Examples:
Contribution Checklist