Define http_listener if CPPREST_FORCE_HTTP_LISTENER_ASIO is defined#608
Merged
ras0219-msft merged 1 commit intomicrosoft:masterfrom Nov 23, 2017
Merged
Conversation
Contributor
|
Looks simple, thanks for the PR! I agree, the preprocessor macros are probably in need of a simplification. |
This was referenced Nov 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When cpprestsdk is built with
CPPREST_HTTP_LISTENER_IMPL = asioon Windows, for testing purposes (I'm trying to debug an issue encountered on Linux), the following complete source code fails to compile:This is a one-line fix. (It's possible that the various preprocessor conditional expressions in this header should all be made more consistent.)