Define http_listener if CPPREST_FORCE_HTTP_LISTENER_ASIO is defined (part 2)#612
Merged
ras0219-msft merged 4 commits intomicrosoft:masterfrom Jan 24, 2018
Merged
Conversation
…ISTENER_ASIO is defined
…me length exceeded, name was truncated" generated too late for disable to be effective inside push/pop
…P_LISTENER_ASIO is defined
…ires the compiler to capture 'this' but the current default capture mode does not allow it"; the issue and workaround is the same as for GCC 4.7 in commit:5244af7c. (cherry picked from commit d0ce63e)
|
|
Contributor
|
This looks great to me; I'll be happy to merge once the CLA is handled! |
Contributor
Author
|
Thank you, @ras0219-msft, and thanks for your patience. I'm told the CLA approval is on its way ...slowly! |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #608, which it turns out was too simple; sorry, @ras0219-msft.
Getting
http_listeneritself defined wasn't enough. This PR, along with PR #611, completes things. The main commit is 823f3b7, which makes surehttp_listener_implandhttp_server_apiare defined. The other three small commits resolve some compiler warnings (and errors on VS 2013, already discussed in PR #609) and enable an additional test case appropriate when asio is in use. I haven't merged PR #611 into this, since it stands alone, but in my environment that's necessary also.