Fix a build problem on Clang.#732
Merged
ras0219-msft merged 1 commit intomicrosoft:masterfrom Aug 3, 2018
Merged
Conversation
AND_CAPTURE_MEMBER_FUNCTION_POINTERS workaround had a check for GCC, but did not exclude Clang. Clang has a fake GCC version of 4.2, thus caused problems.
Contributor
|
Thanks! |
moriarty
added a commit
to moriarty/cpprestsdk
that referenced
this pull request
Oct 17, 2018
These were disabled as a quick fix for microsoft#778 in microsoft#779. * no-format-truncation was properly fixed in microsoft#787 * no-unused-lamda-capture was worked around in microsoft#732 * gaurds for gcc 5.4 were added in microsoft#849 but with microsoft#787 aren't needed
BillyONeal
pushed a commit
that referenced
this pull request
Oct 17, 2018
* Re-enable no-unused-lamda-capture and no-format-trucation These were disabled as a quick fix for #778 in #779. * no-format-truncation was properly fixed in #787 * no-unused-lamda-capture was worked around in #732 * gaurds for gcc 5.4 were added in #849 but with #787 aren't needed * re-enable warning: -Wdelete-non-virtual-dtor - Was disabled in #779 and fixed in #844
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AND_CAPTURE_MEMBER_FUNCTION_POINTERS workaround had a check for GCC, but did not exclude Clang. Clang has a fake GCC version of 4.2, thus caused problems.