Re-enable no-unused-lamda-capture and no-format-trucation#923
Merged
BillyONeal merged 2 commits intomicrosoft:masterfrom Oct 17, 2018
Merged
Re-enable no-unused-lamda-capture and no-format-trucation#923BillyONeal merged 2 commits intomicrosoft:masterfrom
BillyONeal merged 2 commits intomicrosoft:masterfrom
Conversation
These were disabled as a quick fix for microsoft#778 in microsoft#779. * no-format-truncation was properly fixed in microsoft#787 * no-unused-lamda-capture was worked around in microsoft#732 * gaurds for gcc 5.4 were added in microsoft#849 but with microsoft#787 aren't needed
Contributor
Author
|
I didn't re-enable the -Wdelete-non-virtual-dtor because at first I couldn't find when it had been fixed. It looks like this repo uses squash-and-merge so I will push a new commit to this branch. |
- Was disabled in microsoft#779 and fixed in microsoft#844
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were disabled as a quick fix for #778 in #779.
I did the original quick fix of disabling the warnings, and I meant to come back and fix them when I had time.