Skip to content

Conversation

@kennykerr
Copy link
Collaborator

The following PRs introduced bugs. The CI build didn't catch them because the tests just crashed, leaving them undetected.

#1008 had a change to consuming events but the test threw an exception on the producing side which has never been supported. This removes those tests. @sylveon

#992 never worked as intended. @dfields-msft

@kennykerr
Copy link
Collaborator Author

Confirmed all tests have run and passed.

@kennykerr kennykerr merged commit 0a0062a into master Sep 1, 2021
@kennykerr kennykerr deleted the fix_build branch September 1, 2021 20:03
@dfields-msft
Copy link
Contributor

What task tracks fixing the tests/CI pipeline to detect crashes as failures?

@kennykerr
Copy link
Collaborator Author

There isn't anything. Unfortunately, we don't have any budget for improving the build but it would be nice to get this fixed.

@dfields-msft
Copy link
Contributor

I filed #1010 to track, and spent a little while this afternoon looking into it. Here's a potentially simple fix: #1011

@dfields-msft
Copy link
Contributor

Also sorry for introducing the silent failures in the first place... I had some confusion about how Catch2 deals with tests that validate exception throwing and mistakenly believed that running with -e was required, and was passing (which is how it is logged, rather than skipping which is what it actually does...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants